Fix DBIx::Class ordered test CODE weaken GC stall#787
Merged
Conversation
Keep the CODE weak-ref cleanup path targeted to the CODE referent instead of running a full ReachabilityWalker sweep from WeakRefRegistry.weaken(). DBIx::Class weakens callback CODE refs in hot cursor paths, and the broad sweep was forcing repeated explicit old-GC cycles in t/87ordered.t. Generated with Codex (https://openai.com/codex) Co-Authored-By: Codex <codex@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
weaken(CODE)path.DBIx::Classt/87ordered.tstall caused by repeated explicit old-GC cycles.Investigation
jstackon the stuckt/87ordered.tchild showed the main thread inside:JFR confirmed the process was not blocked in SQL or DBIC logic: a 20s recording had 519
System.gc()/ old-GC events.Verification
maketimeout 120 ./jperl src/test/resources/unit/refcount/subquote_defer_weak_cleanup.ttimeout 120 ./jperl src/test/resources/unit/refcount/weaken_closure_argument.ttimeout 600 ./jperl -Iblib/lib -Iblib/arch t/87ordered.tfrom the DBIx-Class build dirThe direct DBIC check passed
1..1271withAuto checked 5 references for leaks - none detected.