Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .yarnrc.yml
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
catalog:
'@types/node': 'npm:@types/node@24.12.2'
vite: 'npm:@voidzero-dev/vite-plus-core@latest'
vite-plus: latest
vitest: 'npm:@voidzero-dev/vite-plus-test@latest'
vite: 'npm:@voidzero-dev/vite-plus-core@0.1.20-alpha.4'
vite-plus: 0.1.20-alpha.4
vitest: 'npm:@voidzero-dev/vite-plus-test@0.1.20-alpha.4'

nodeLinker: node-modules

Expand Down
6 changes: 3 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -37,12 +37,12 @@
"oxc-parser": "^0.126.0",
"prettier": "^3.8.3",
"typescript": "^6.0.3",
"vite-plus": "^0.1.18",
"vite-plus": "0.1.20-alpha.4",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The project is utilizing Yarn 4 catalogs as defined in .yarnrc.yml. To maintain a single source of truth and ensure consistency across the workspace, this dependency should use the catalog: protocol instead of a hardcoded version string.

Suggested change
"vite-plus": "0.1.20-alpha.4",
"vite-plus": "catalog:",

"vitest": "^4.1.4"
},
"resolutions": {
"vite": "npm:@voidzero-dev/vite-plus-core@latest",
"vitest": "npm:@voidzero-dev/vite-plus-test@latest"
"vite": "npm:@voidzero-dev/vite-plus-core@0.1.20-alpha.4",
"vitest": "npm:@voidzero-dev/vite-plus-test@0.1.20-alpha.4"
Comment on lines +44 to +45
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The resolutions for vite and vitest should also leverage the catalog entries defined in .yarnrc.yml. This ensures that the versions used for resolutions stay in sync with the rest of the project and avoids duplication of the version string, especially since these resolutions point to specific forked packages.

Suggested change
"vite": "npm:@voidzero-dev/vite-plus-core@0.1.20-alpha.4",
"vitest": "npm:@voidzero-dev/vite-plus-test@0.1.20-alpha.4"
"vite": "catalog:",
"vitest": "catalog:"

},
"packageManager": "yarn@4.13.0"
}
Loading