Skip to content

chore: upgrade vite-plus to 0.1.20-alpha.4#2

Draft
fengmk2 wants to merge 1 commit into
mainfrom
update-vite-plus-alpha-0.1.20-alpha.4
Draft

chore: upgrade vite-plus to 0.1.20-alpha.4#2
fengmk2 wants to merge 1 commit into
mainfrom
update-vite-plus-alpha-0.1.20-alpha.4

Conversation

@fengmk2
Copy link
Copy Markdown
Owner

@fengmk2 fengmk2 commented Apr 28, 2026

Upgrade vite-plus and related packages to 0.1.20-alpha.4 alpha version.

@fengmk2 fengmk2 self-assigned this Apr 28, 2026
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates several dependencies, including vite-plus, oxfmt, oxlint, and related packages, to newer versions. I have reviewed the changes and suggest leveraging the Yarn catalog protocol in package.json for vite-plus, vite, and vitest to maintain a single source of truth and ensure consistency across the project.

Comment thread package.json
"prettier": "^3.8.3",
"typescript": "^6.0.3",
"vite-plus": "^0.1.18",
"vite-plus": "0.1.20-alpha.4",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The project is utilizing Yarn 4 catalogs as defined in .yarnrc.yml. To maintain a single source of truth and ensure consistency across the workspace, this dependency should use the catalog: protocol instead of a hardcoded version string.

Suggested change
"vite-plus": "0.1.20-alpha.4",
"vite-plus": "catalog:",

Comment thread package.json
Comment on lines +44 to +45
"vite": "npm:@voidzero-dev/vite-plus-core@0.1.20-alpha.4",
"vitest": "npm:@voidzero-dev/vite-plus-test@0.1.20-alpha.4"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The resolutions for vite and vitest should also leverage the catalog entries defined in .yarnrc.yml. This ensures that the versions used for resolutions stay in sync with the rest of the project and avoids duplication of the version string, especially since these resolutions point to specific forked packages.

Suggested change
"vite": "npm:@voidzero-dev/vite-plus-core@0.1.20-alpha.4",
"vitest": "npm:@voidzero-dev/vite-plus-test@0.1.20-alpha.4"
"vite": "catalog:",
"vitest": "catalog:"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant