Skip to content

fix(chart): include service port in default apiBaseUrl #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ianstanton wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(chart): include service port in default apiBaseUrl #217

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion install/kubernetes/github-actions-cache-server/templates/_helpers.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ Generate environment variables from config values.
- name: PORT
value: "3000"
- name: API_BASE_URL
value: {{ default (printf "http://%s.%s.svc.cluster.local" (include "github-actions-cache-server.fullname" .) .Release.Namespace) .Values.config.apiBaseUrl | quote }}
value: {{ default (printf "http://%s.%s.svc.cluster.local:%v" (include "github-actions-cache-server.fullname" .) .Release.Namespace .Values.service.port) .Values.config.apiBaseUrl | quote }}
- name: ENABLE_DIRECT_DOWNLOADS
value: {{ .Values.config.enableDirectDownloads | quote }}
- name: CACHE_CLEANUP_OLDER_THAN_DAYS
Expand Down