fix(chart): include service port in default apiBaseUrl#217
Open
ianstanton wants to merge 1 commit intofalcondev-oss:masterfrom
Open
fix(chart): include service port in default apiBaseUrl#217ianstanton wants to merge 1 commit intofalcondev-oss:masterfrom
ianstanton wants to merge 1 commit intofalcondev-oss:masterfrom
Conversation
The default API_BASE_URL omitted the service port, causing the server to return signed upload URLs pointing at port 80 (e.g. http://<service>.<ns>.svc.cluster.local/upload/<id>). Runners connecting to port 80 would get their TCP packets dropped by iptables on the ClusterIP, causing cache uploads to hang indefinitely at 0%. Fix: include .Values.service.port in the printf format so the default stays consistent with however the service port is configured. Fixes falcondev-oss#215 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default
API_BASE_URLomits the service port, causing the server to return upload URLs pointing at port 80. On Kubernetes, connections to a ClusterIP on an undefined port are silently dropped by iptables, so cache uploads hang indefinitely at 0%.This broke when the default service port changed from 80 to 3000 (see #215).
Fix: include
.Values.service.portin the printf format so the default stays consistent with the configured service port.