Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions packages/react-dom-bindings/src/client/ReactFiberConfigDOM.js
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,7 @@ import {
getPropsFromElement,
diffHydratedText,
trapClickOnNonInteractiveElement,
restoreControlledState,
} from './ReactDOMComponent';
import {hydrateInput} from './ReactDOMInput';
import {hydrateTextarea} from './ReactDOMTextarea';
Expand Down Expand Up @@ -6644,8 +6645,27 @@ export const HostTransitionContext: ReactContext<TransitionStatus> = {
};

export type FormInstance = HTMLFormElement;

function restoreControlledFormControlState(element: Element) {
const internalInstance = getInstanceFromNode(element);
if (internalInstance === null || internalInstance.tag !== HostComponent) {
return;
}
const stateNode = internalInstance.stateNode;
if (stateNode !== element) {
return;
}
const props = getFiberCurrentPropsFromNode(stateNode);
restoreControlledState(stateNode, internalInstance.type, props);
}

export function resetFormInstance(form: FormInstance): void {
ReactBrowserEventEmitterSetEnabled(true);
form.reset();
ReactBrowserEventEmitterSetEnabled(false);

const elements = form.elements;
for (let i = 0; i < elements.length; i++) {
restoreControlledFormControlState((elements[i]: any));
}
}
46 changes: 46 additions & 0 deletions packages/react-dom/src/__tests__/ReactDOMForm-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -1647,6 +1647,52 @@ describe('ReactDOMForm', () => {
expect(inputRef.current.value).toEqual('0');
});

it('should restore a controlled select after automatic form reset', async () => {
const formRef = React.createRef();
const selectRef = React.createRef();

function App() {
const [value, setValue] = useState('2');

return (
<form
ref={formRef}
action={async formData => {
Scheduler.log(`Async action started`);
await getText('Wait');
}}>
<select
ref={selectRef}
name="type"
value={value}
onChange={event => setValue(event.currentTarget.value)}>
<option value="1">1</option>
<option value="2">2</option>
<option value="3">3</option>
</select>
</form>
);
}

const root = ReactDOMClient.createRoot(container);
await act(() => root.render(<App />));

expect(selectRef.current.value).toEqual('2');

// Submit the form. This will trigger an async action.
await submit(formRef.current);
assertLog(['Async action started']);

// We haven't reset yet.
expect(selectRef.current.value).toEqual('2');

// Action completes. The controlled select is restored after the native
// form reset runs.
await act(() => resolveText('Wait'));
assertLog([]);
expect(selectRef.current.value).toEqual('2');
});

it('requestFormReset schedules a form reset after transition completes', async () => {
// This is the same as the previous test, except the form is updated with
// a userspace action instead of a built-in form action.
Expand Down