Restore controlled form state after reset#36388
Open
raashish1601 wants to merge 1 commit intofacebook:mainfrom
Open
Restore controlled form state after reset#36388raashish1601 wants to merge 1 commit intofacebook:mainfrom
raashish1601 wants to merge 1 commit intofacebook:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #30580.
Automatic form resets call the browser's native
form.reset(), which can reset a controlled<select>to the first option before React has a chance to restore the controlled value. Restore React-managed form controls after the native reset so controlled selects keep theirvalue, matching the behavior users expect from controlled inputs.How did you test this change?
corepack yarn test ReactDOMForm-test --runInBand --testNamePattern="restore a controlled select"(fails before the implementation change, passes after)corepack yarn test ReactDOMForm-testcorepack yarn test --prod ReactDOMForm-testcorepack yarn prettiercorepack yarn linc./node_modules/.bin/flow.cmd statuswith the generateddom-browserFlow config