[DevTools] chore: extract pure functions from fiber/renderer.js#35924
Open
[DevTools] chore: extract pure functions from fiber/renderer.js#35924
Conversation
hoxyq
changed the title
hoxyq
force-pushed
the
devtools/chore
branch
from
75ec6f5 to
5dcebdc
Compare
hoxyq
force-pushed
the
devtools/chore
branch
from
5dcebdc to
ca8fc27
Compare
eps1lon
reviewed
Feb 28, 2026
| isErrorBoundary, | ||
| getSecondaryEnvironmentName, | ||
| areEqualRects, | ||
| } from './shared/DevToolsFiberUtils'; |
Collaborator
There was a problem hiding this comment.
I'd rather we separate things by feature and not introduce yet another utils dumping ground in DevTools.
eps1lon
reviewed
Feb 28, 2026
| ioExistsInSuspenseAncestor, | ||
| getAwaitInSuspendedByFromIO, | ||
| getVirtualEndTime, | ||
| } from './shared/DevToolsFiberSuspenseUtils'; |
Collaborator
There was a problem hiding this comment.
Suggested change
| } from './shared/DevToolsFiberSuspenseUtils'; | |
| } from './shared/DevToolsFiberSuspense'; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am in a process of splitting down the renderer implementation into smaller units of logic that can be reused. This change is about extracting pure functions only.