Skip to content

Expose RuntimeExecutor on ReactContext #56987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
javache wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Expose RuntimeExecutor on ReactContext #56987

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/react-native/ReactAndroid/api/ReactAndroid.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -967,6 +967,7 @@ public abstract class com/facebook/react/bridge/ReactContext : android/content/C
public abstract fun getNativeModule (Ljava/lang/String;)Lcom/facebook/react/bridge/NativeModule;
public abstract fun getNativeModules ()Ljava/util/Collection;
public fun getNativeModulesMessageQueueThread ()Lcom/facebook/react/bridge/queue/MessageQueueThread;
public abstract fun getRuntimeExecutor ()Lcom/facebook/react/bridge/RuntimeExecutor;
public fun getScrollEndedListeners ()Lcom/facebook/react/bridge/ScrollEndedListeners;
public abstract fun getSourceURL ()Ljava/lang/String;
public fun getSystemService (Ljava/lang/String;)Ljava/lang/Object;
Expand Down Expand Up @@ -4162,6 +4163,7 @@ public final class com/facebook/react/uimanager/ThemedReactContext : com/faceboo
public fun getNativeModule (Ljava/lang/String;)Lcom/facebook/react/bridge/NativeModule;
public fun getNativeModules ()Ljava/util/Collection;
public final fun getReactApplicationContext ()Lcom/facebook/react/bridge/ReactApplicationContext;
public fun getRuntimeExecutor ()Lcom/facebook/react/bridge/RuntimeExecutor;
public fun getScrollEndedListeners ()Lcom/facebook/react/bridge/ScrollEndedListeners;
public fun getSourceURL ()Ljava/lang/String;
public final fun getSurfaceID ()Ljava/lang/String;
Expand Down
5 changes: 5 additions & 0 deletions ...react-native/ReactAndroid/src/main/java/com/facebook/react/bridge/BridgeReactContext.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,4 +312,9 @@ public void registerSegment(int segmentId, String path, Callback callback) {
Assertions.assertNotNull(mCatalystInstance).registerSegment(segmentId, path);
Assertions.assertNotNull(callback).invoke();
}

@Override
public @Nullable RuntimeExecutor getRuntimeExecutor() {
return mCatalystInstance == null ? null : mCatalystInstance.getRuntimeExecutor();
}
}
6 changes: 6 additions & 0 deletions packages/react-native/ReactAndroid/src/main/java/com/facebook/react/bridge/ReactContext.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,6 +200,12 @@ public LifecycleState getLifecycleState() {
return mLifecycleState;
}

/**
* Returns the {@link RuntimeExecutor} for the underlying JavaScript runtime, or {@code null} if
* the runtime has not been initialized. Works in both bridged and bridgeless modes.
*/
public abstract @Nullable RuntimeExecutor getRuntimeExecutor();

/**
* This allows scroll views to notify NativeAnimatedModule when user-driven scrolling ends.
*
Expand Down
3 changes: 3 additions & 0 deletions ...ct-native/ReactAndroid/src/main/java/com/facebook/react/runtime/BridgelessReactContext.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ import com.facebook.react.bridge.JavaScriptModuleRegistry
import com.facebook.react.bridge.NativeModule
import com.facebook.react.bridge.ReactApplicationContext
import com.facebook.react.bridge.ReactSoftExceptionLogger.logSoftException
import com.facebook.react.bridge.RuntimeExecutor
import com.facebook.react.bridge.UIManager
import com.facebook.react.common.annotations.FrameworkAPI
import com.facebook.react.common.annotations.UnstableReactNativeAPI
Expand Down Expand Up @@ -180,4 +181,6 @@ internal class BridgelessReactContext(context: Context, private val reactHost: R
}

override fun getJSCallInvokerHolder(): CallInvokerHolder? = reactHost.jsCallInvokerHolder

override fun getRuntimeExecutor(): RuntimeExecutor? = reactHost.runtimeExecutor
}
3 changes: 3 additions & 0 deletions ...eact-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/ThemedReactContext.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ import com.facebook.react.bridge.LifecycleEventListener
import com.facebook.react.bridge.NativeModule
import com.facebook.react.bridge.ReactApplicationContext
import com.facebook.react.bridge.ReactContext
import com.facebook.react.bridge.RuntimeExecutor
import com.facebook.react.bridge.ScrollEndedListeners
import com.facebook.react.bridge.UIManager
import com.facebook.react.common.annotations.internal.LegacyArchitecture
Expand Down Expand Up @@ -162,6 +163,8 @@ public class ThemedReactContext(
override fun getJSCallInvokerHolder(): CallInvokerHolder? =
reactApplicationContext.getJSCallInvokerHolder()

override fun getRuntimeExecutor(): RuntimeExecutor? = reactApplicationContext.runtimeExecutor

@Deprecated(
"This method is deprecated, please use UIManagerHelper.getUIManager() instead.",
ReplaceWith("UIManagerHelper.getUIManager()"),
Expand Down
Loading