Expose RuntimeExecutor on ReactContext#56987
Open
javache wants to merge 1 commit into
Open
Conversation
Summary: Add `ReactContext.getRuntimeExecutor()` so callers can obtain the `RuntimeExecutor` without reaching into `CatalystInstance`. The bridge subclass forwards to `CatalystInstance.getRuntimeExecutor()`; the bridgeless subclass forwards to `ReactHost.runtimeExecutor`; `ThemedReactContext` proxies to its wrapped `ReactApplicationContext`. Previously, callers that needed the runtime executor had to reach through `catalystInstance.getRuntimeExecutor()`, which is bridge-only and required a `NoGetCatalystInstance` lint suppression. The new accessor works uniformly in both bridged and bridgeless modes. Changelog: [Android][Added] - Add `ReactContext.getRuntimeExecutor()` Differential Revision: D106647233
meta-cla
Bot
added
the
CLA Signed
|
@javache has exported this pull request. If you are a Meta employee, you can view the originating Diff in D106647233. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Add
ReactContext.getRuntimeExecutor()so callers can obtain theRuntimeExecutorwithout reaching intoCatalystInstance. The bridge subclass forwards toCatalystInstance.getRuntimeExecutor(); the bridgeless subclass forwards toReactHost.runtimeExecutor;ThemedReactContextproxies to its wrappedReactApplicationContext. Previously, callers that needed the runtime executor had to reach throughcatalystInstance.getRuntimeExecutor(), which is bridge-only and required aNoGetCatalystInstancelint suppression. The new accessor works uniformly in both bridged and bridgeless modes.Changelog:
[Android][Added] - Add
ReactContext.getRuntimeExecutor()Differential Revision: D106647233