Skip to content

LogBoxData test migrated to Jest modern timers #55757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chicio wants to merge 2 commits into
base: main
Choose a base branch
from
+17 −7
Open

LogBoxData test migrated to Jest modern timers #55757

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
421894e
fix: migrate LogBoxData-test to jest modern timers
chicio Feb 25, 2026
9f89bcc
Merge branch 'main' into logboxdata_jest_timers
chicio Feb 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 17 additions & 7 deletions packages/react-native/Libraries/LogBox/Data/__tests__/LogBoxData-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,6 @@

'use strict';

// TODO(legacy-fake-timers): Fix these tests to work with modern timers.
jest.useFakeTimers({legacyFakeTimers: true});

jest.mock('../../../Core/Devtools/parseErrorStack', () => {
return {__esModule: true, default: jest.fn(() => [])};
});
Expand Down Expand Up @@ -144,16 +141,17 @@ const addSyntaxError = (options: $FlowFixMe) => {
);
};

beforeEach(() => {
jest.resetModules();
});

const flushToObservers = () => {
// Observer updates are debounced and need to advance timers to flush.
jest.runOnlyPendingTimers();
};

describe('LogBoxData', () => {
beforeEach(() => {
jest.useFakeTimers();
jest.resetModules();
});

it('adds and dismisses logs', () => {
addLogs(['A']);
addSoftErrors(['B']);
Expand Down Expand Up @@ -590,9 +588,13 @@ describe('LogBoxData', () => {
expect(observer.mock.calls.length).toBe(1);

addLogs(['A']);
flushToObservers();
addSoftErrors(['B']);
flushToObservers();
addFatalErrors(['C']);
flushToObservers();
addSyntaxError();
flushToObservers();
expect(observer.mock.calls.length).toBe(5);

LogBoxData.clearWarnings();
Expand All @@ -610,9 +612,13 @@ describe('LogBoxData', () => {
expect(observer.mock.calls.length).toBe(1);

addLogs(['A']);
flushToObservers();
addSoftErrors(['B']);
flushToObservers();
addFatalErrors(['C']);
flushToObservers();
addSyntaxError();
flushToObservers();
expect(observer.mock.calls.length).toBe(5);

LogBoxData.clearErrors();
Expand Down Expand Up @@ -854,4 +860,8 @@ describe('LogBoxData', () => {
expect(Array.from(observerAfter.mock.calls[0][0].logs).length).toBe(0);
});
});

afterEach(() => {
jest.useRealTimers();
});
});
Loading