LogBoxData test migrated to Jest modern timers#55757
Open
chicio wants to merge 2 commits intofacebook:mainfrom
Open
LogBoxData test migrated to Jest modern timers#55757chicio wants to merge 2 commits intofacebook:mainfrom
chicio wants to merge 2 commits intofacebook:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This PR migrates the LogBoxData tests so that it uses Jest modern timers.
I removed the
legacyFakeTimersproperty fromuseFakeTimers(like I did in the previous PR for Pressability tests #55410), and moved it to abeforeEach. This in combination with restoring real timers inafterEachimproves tests reliability and isolation.Then I modified some tests that started to fail by adding explicit
flushToObservers().The extra flushToObservers() calls are necessary because addLog/addException schedule processing using
setImmediate, and inside that callbackhandleUpdate()schedules observer notifications using anothersetImmediate(so we need to flush twice to simulate the correct behaviour like it was already done in some other tests in the test suite).Changelog:
[GENERAL] [CHANGED] - Migrated LogBoxData tests to Jest modern timers
Test Plan:
handleUpdatecall inaddException, that changes the call to theobserver)