Skip to content

Fix crash in tracking spring animations when toValue node is detached #55734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kmsbernard wants to merge 2 commits into
base: main
Choose a base branch
from
+43 −1
Open

Fix crash in tracking spring animations when toValue node is detached #55734

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c6e3a17
[Android][NativeAnimated] Add regression test for detached tracking s…
kmsbernard Feb 25, 2026
2579213
[Android][NativeAnimated] Guard tracking spring when toValue node is …
kmsbernard Feb 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion ...act-native/ReactAndroid/src/main/java/com/facebook/react/animated/TrackingAnimatedNode.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,11 @@ internal class TrackingAnimatedNode(
if (valAnimatedNode != null) {
animationConfig.putDouble("toValue", valAnimatedNode.getValue())
} else {
animationConfig.putNull("toValue")
val drivenNode = nativeAnimatedNodesManager.getNodeById(valueNode) as? ValueAnimatedNode
if (drivenNode == null) {
return
}
animationConfig.putDouble("toValue", drivenNode.getValue())
}
nativeAnimatedNodesManager.startAnimatingNode(animationId, valueNode, animationConfig, null)
}
Expand Down
38 changes: 38 additions & 0 deletions ...ReactAndroid/src/test/java/com/facebook/react/animated/NativeAnimatedNodeTraversalTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1370,6 +1370,44 @@ class NativeAnimatedNodeTraversalTest {
assertThat(previousValue).isEqualTo(1.5)
}

@Test
fun testTrackingSpringDoesNotCrashWhenToValueNodeIsDetached() {
val springConfig: JavaOnlyMap =
JavaOnlyMap.of(
"type",
"spring",
"stiffness",
230.2,
"damping",
22.0,
"mass",
1.0,
"initialVelocity",
0.0,
"restSpeedThreshold",
0.001,
"restDisplacementThreshold",
0.001,
"overshootClamping",
false,
)

createAnimatedGraphWithTrackingNode(springConfig)

nativeAnimatedNodesManager.setAnimatedNodeValue(1, 1.0)
nativeAnimatedNodesManager.runUpdates(nextFrameTime())

nativeAnimatedNodesManager.disconnectAnimatedNodes(1, 2)
nativeAnimatedNodesManager.dropAnimatedNode(1)

nativeAnimatedNodesManager.runUpdates(nextFrameTime())

val trackedNode = nativeAnimatedNodesManager.getNodeById(3) as? ValueAnimatedNode
assertThat(trackedNode).isNotNull
val trackedValue = checkNotNull(trackedNode).getValue()
assertThat(trackedValue.isNaN()).isFalse
}

companion object {
private const val FRAME_LEN_NANOS: Long = 1000000000L / 60L
private const val INITIAL_FRAME_TIME_NANOS: Long = 14599233201256L /* random */
Expand Down
Loading