Fix crash in tracking spring animations when toValue node is detached#55734
Open
kmsbernard wants to merge 2 commits intofacebook:mainfrom
Open
Fix crash in tracking spring animations when toValue node is detached#55734kmsbernard wants to merge 2 commits intofacebook:mainfrom
kmsbernard wants to merge 2 commits intofacebook:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This PR fixes an Android Native Animated crash in tracking + spring animations when the tracked
toValuenode is detached.In
TrackingAnimatedNode.update, if the tracked node could not be resolved, we used to writetoValue = nullintoanimationConfig.SpringAnimation.resetConfigexpectstoValueto be a number, so this could crash withNullPointerException: null cannot be cast to non-null type kotlin.NumberThis can happen in real apps during graph teardown (for example unmount/re-render/navigation transitions), where tracking may still update for a transient frame after the tracked node has been detached.
Fix:
toValuefromTrackingAnimatedNode.This PR also adds a regression test.
Changelog:
[ANDROID] [FIXED] - Prevent Native Animated tracking spring crash when tracked
toValuenode is detached.Test Plan:
Added regression test
NativeAnimatedNodeTraversalTest.testTrackingSpringDoesNotCrashWhenToValueNodeIsDetachedNullPointerException: null cannot be cast to non-null type kotlin.Number