Skip to content

Allow BenchmarkProblem to take in custom BenchmarkRunner #4948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sunnyshen321 wants to merge 1 commit into
base: main
Choose a base branch
from
+13 −5
Open

Allow BenchmarkProblem to take in custom BenchmarkRunner #4948

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions ax/benchmark/benchmark.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -576,11 +576,17 @@ def run_optimization_with_orchestrator(
include_status_quo=sq_arm is not None,
logging_level=orchestrator_logging_level,
)
runner = get_benchmark_runner(
problem=problem,
max_concurrency=orchestrator_options.max_pending_trials,
force_use_simulated_backend=method.early_stopping_strategy is not None,
)

# Use custom runner if provided on the problem, otherwise create standard runner
if problem.runner is not None:
runner = problem.runner
else:
runner = get_benchmark_runner(
problem=problem,
max_concurrency=orchestrator_options.max_pending_trials,
force_use_simulated_backend=method.early_stopping_strategy is not None,
)

experiment = Experiment(
name=f"{problem.name}|{method.name}_{int(time())}",
search_space=problem.search_space,
Expand Down
2 changes: 2 additions & 0 deletions ax/benchmark/benchmark_problem.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
from dataclasses import dataclass, field

from ax.benchmark.benchmark_metric import BenchmarkMapMetric, BenchmarkMetric
from ax.benchmark.benchmark_runner import BenchmarkRunner
from ax.benchmark.benchmark_step_runtime_function import TBenchmarkStepRuntimeFunction
from ax.benchmark.benchmark_test_function import BenchmarkTestFunction
from ax.benchmark.noise import GaussianNoise, Noise
Expand Down Expand Up @@ -107,6 +108,7 @@ class BenchmarkProblem(Base):
dict[AuxiliaryExperimentPurpose, list[AuxiliaryExperiment]] | None
) = None
tracking_metrics: list[Metric] | None = None
runner: BenchmarkRunner | None = None

def __post_init__(self) -> None:
# Handle backward compatibility for noise_std parameter
Expand Down