Allow BenchmarkProblem to take in custom BenchmarkRunner#4948
Open
sunnyshen321 wants to merge 1 commit intofacebook:mainfrom
Open
Allow BenchmarkProblem to take in custom BenchmarkRunner#4948sunnyshen321 wants to merge 1 commit intofacebook:mainfrom
BenchmarkProblem to take in custom BenchmarkRunner#4948sunnyshen321 wants to merge 1 commit intofacebook:mainfrom
Conversation
Summary: `BenchmarkRunner` by default assumes all trials are completed in `poll_trial_status`. We need a custom runner (`FailureAwareBenchmarkRunner` from previous diff) to override `poll_trial_status` which stores trial status depending on if the trial data is NaN (should be abandoned) or is available (completed) Differential Revision: D87091317
meta-cla
bot
added
the
CLA Signed
|
@sunnyshen321 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D87091317. |
sunnyshen321
pushed a commit
to sunnyshen321/Ax
that referenced
this pull request
Feb 26, 2026
…k#4948) Summary: `BenchmarkRunner` by default assumes all trials are completed in `poll_trial_status`. We need a custom runner (`FailureAwareBenchmarkRunner` from previous diff) to override `poll_trial_status` which stores trial status depending on if the trial data is NaN (should be abandoned) or is available (completed) Differential Revision: D87091317
sunnyshen321
pushed a commit
to sunnyshen321/Ax
that referenced
this pull request
Feb 26, 2026
…k#4948) Summary: `BenchmarkRunner` by default assumes all trials are completed in `poll_trial_status`. We need a custom runner (`FailureAwareBenchmarkRunner` from previous diff) to override `poll_trial_status` which stores trial status depending on if the trial data is NaN (should be abandoned) or is available (completed) Differential Revision: D87091317
sunnyshen321
pushed a commit
to sunnyshen321/Ax
that referenced
this pull request
Feb 26, 2026
…k#4948) Summary: `BenchmarkRunner` by default assumes all trials are completed in `poll_trial_status`. We need a custom runner (`FailureAwareBenchmarkRunner` from previous diff) to override `poll_trial_status` which stores trial status depending on if the trial data is NaN (should be abandoned) or is available (completed) Differential Revision: D87091317
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
BenchmarkRunnerby default assumes all trials are completed inpoll_trial_status. We need a custom runner (FailureAwareBenchmarkRunnerfrom previous diff) to overridepoll_trial_statuswhich stores trial status depending on if the trial data is NaN (should be abandoned) or is available (completed)Differential Revision: D87091317