Skip to content

[eas-cli] eas go: use SDK version from current project when available#3776

Merged
gwdp merged 2 commits into
mainfrom
gwdp/eas-go-project-sdk-default
May 21, 2026
Merged

[eas-cli] eas go: use SDK version from current project when available#3776
gwdp merged 2 commits into
mainfrom
gwdp/eas-go-project-sdk-default

Conversation

@gwdp
Copy link
Copy Markdown
Contributor

@gwdp gwdp commented May 21, 2026

Why

When running eas go in an Expo project, the SDK version is already specified in app.json or app.config.js, and the user likely wants to use that specific SDK version.

How

  • Added detectProjectSdkVersionAsync which reads sdkVersion from the local Expo config via getPrivateExpoConfigAsync. Skips gracefully if no config file is present or the read fails.
  • Uses the detected version as the default when --sdk-version is not passed.
  • Logs "Current project using SDK X" (informational) when a version is detected and not overridden by the flag.
  • Updated dispatchWorkflowAsync to return the server-resolved sdkVersion from the repack configuration response, and logs ✓ Using Expo Go SDK X after the server confirms the version is supported as a way to provide feedback on which version is being used.

Test Plan

  • CI
  • Local test within an Expo project using SDK 55 and 56

Copy link
Copy Markdown
Contributor Author

gwdp commented May 21, 2026

@codecov
Copy link
Copy Markdown

codecov Bot commented May 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57.08%. Comparing base (fa6c877) to head (f9f5bbb).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3776      +/-   ##
==========================================
+ Coverage   56.80%   57.08%   +0.29%     
==========================================
  Files         904      905       +1     
  Lines       39112    39219     +107     
  Branches     8173     8198      +25     
==========================================
+ Hits        22214    22385     +171     
+ Misses      15428    15364      -64     
  Partials     1470     1470              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gwdp gwdp force-pushed the gwdp/eas-go-project-sdk-default branch 6 times, most recently from c067556 to b22a7d9 Compare May 21, 2026 20:01
@gwdp gwdp requested a review from sjchmiela May 21, 2026 20:05
@gwdp gwdp force-pushed the gwdp/eas-go-project-sdk-default branch from b22a7d9 to 41bb027 Compare May 21, 2026 20:47
@gwdp gwdp force-pushed the gwdp/eas-go-project-sdk-default branch from 41bb027 to e920824 Compare May 21, 2026 20:55
@github-actions
Copy link
Copy Markdown

✅ Thank you for adding the changelog entry!

@gwdp gwdp marked this pull request as ready for review May 21, 2026 21:05
@github-actions
Copy link
Copy Markdown

Subscribed to pull request

File Patterns Mentions
**/* @douglowder

Generated by CodeMention

@gwdp gwdp merged commit ea2cd4f into main May 21, 2026
12 checks passed
@gwdp gwdp deleted the gwdp/eas-go-project-sdk-default branch May 21, 2026 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants