[eas-cli] eas go: use SDK version from current project when available#3776
Merged
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3776 +/- ##
==========================================
+ Coverage 56.80% 57.08% +0.29%
==========================================
Files 904 905 +1
Lines 39112 39219 +107
Branches 8173 8198 +25
==========================================
+ Hits 22214 22385 +171
+ Misses 15428 15364 -64
Partials 1470 1470 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
c067556 to
b22a7d9
Compare
sjchmiela
approved these changes
May 21, 2026
b22a7d9 to
41bb027
Compare
41bb027 to
e920824
Compare
|
✅ Thank you for adding the changelog entry! |
|
Subscribed to pull request
Generated by CodeMention |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Why
When running
eas goin an Expo project, the SDK version is already specified inapp.jsonorapp.config.js, and the user likely wants to use that specific SDK version.How
detectProjectSdkVersionAsyncwhich readssdkVersionfrom the local Expo config viagetPrivateExpoConfigAsync. Skips gracefully if no config file is present or the read fails.--sdk-versionis not passed.dispatchWorkflowAsyncto return the server-resolvedsdkVersionfrom the repack configuration response, and logs✓ Using Expo Go SDK Xafter the server confirms the version is supported as a way to provide feedback on which version is being used.Test Plan