[eas-cli] eas go: prompt for SDK version interactively#3768
Conversation
dbd8131 to
92b05eb
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3768 +/- ##
==========================================
+ Coverage 57.22% 57.24% +0.02%
==========================================
Files 905 905
Lines 39302 39324 +22
Branches 8237 8244 +7
==========================================
+ Hits 22488 22507 +19
- Misses 15344 15347 +3
Partials 1470 1470 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
92b05eb to
3697212
Compare
This stack of pull requests is managed by Graphite. Learn more about stacking. |
69de0dc to
d4d5ecb
Compare
a7dc001 to
1be0b07
Compare
d4d5ecb to
a282d59
Compare
1be0b07 to
9ac0f46
Compare
a282d59 to
68696c5
Compare
9ac0f46 to
e3c980c
Compare
68696c5 to
c69a2f9
Compare
e3c980c to
07b9343
Compare
c067556 to
b22a7d9
Compare
07b9343 to
2ed3f7d
Compare
b22a7d9 to
41bb027
Compare
2ed3f7d to
13b07de
Compare
41bb027 to
e920824
Compare
b492db0 to
625c1a1
Compare
f21a5c0 to
aa88890
Compare
35d71a9 to
a96383f
Compare
a96383f to
95224b2
Compare
|
Subscribed to pull request
Generated by CodeMention |
| return selectAsync( | ||
| 'Select an Expo SDK version', | ||
| selectable.map(v => { | ||
| const major = v.sdkVersion.split('.')[0]; |
There was a problem hiding this comment.
looking at every time we split sdk version by . i wonder if maybe sdkversions from graphql shouldn't have have been just
key: String!
label: String!
isDefault: Boolean!
There was a problem hiding this comment.
I agree with your point about the structure, but if not missing anything, it wouldn't clean up much of the .split('.')[0] because that is only executed once for the GraphQL.
My intention here was to avoid making the server responsible for the presentation layer and instead focus on providing the data needed for the CLI to handle that. I'm happy to bounce more here and come with another iteration if anything we can do better 🙇♂️
Co-authored-by: Stanisław Chmiela <sjchmiela@users.noreply.github.com>
|
✅ Thank you for adding the changelog entry! |

Summary
eas gowhen--sdk-versionis not passed.supportedSdkVersionsfrom the GraphQL API (expo/universe#27451) — returns only versions with an actual repack target, labeled as Latest, Beta, or by major version number.--sdk-versionand current project scope bypasses the prompt entirelyValidation
eas gowithout--sdk-version— prompted with SDK list, latest selected by default.eas go --sdk-version 55.0.0— no prompt, proceeds directly.eas gowithin a 55.x project, auto-selected, no prompt