Skip to content

Conversation

@EvanBacon
Copy link
Contributor

Summary

  • In non-interactive mode, automatically generate and use a bundle identifier / application ID instead of throwing an error
  • Matches the behavior of Expo CLI's getOrPromptApplicationId.ts
  • The generated ID follows the pattern com.{accountName}.{slug} (or uses the other platform's ID if already set)
  • Only throws an error if no valid suggestion can be generated (e.g., GraphQL lookup fails and no fallback available)

Test plan

  • Updated existing tests to verify new auto-generation behavior
  • Added tests for:
    • Auto-generating bundle identifier from account name + slug
    • Using android.package as iOS bundle identifier when available
    • Using ios.bundleIdentifier as Android package when available
    • Still throwing error when no valid suggestion can be generated

🤖 Generated with Claude Code

@github-actions
Copy link

Subscribed to pull request

File Patterns Mentions
**/* @douglowder

Generated by CodeMention

EvanBacon and others added 2 commits February 12, 2026 15:15
Allow iOS bundle identifier and Android application id to be auto-generated in non-interactive mode instead of immediately throwing. If a suggested identifier is available (from AppQuery or the counterpart platform field) it will be used and logged; if not, an error is still thrown. Tests updated to cover auto-generation, cross-platform fallbacks, and the error case when no valid suggestion can be produced.
- Wrap suggestion lookup in try-catch for non-interactive mode
- Add changelog entry for the new feature

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@EvanBacon EvanBacon force-pushed the @evanbacon/cli/auto-bundle-id branch from e9ba060 to 6bfb8af Compare February 12, 2026 23:16
@github-actions
Copy link

✅ Thank you for adding the changelog entry!

@codecov
Copy link

codecov bot commented Feb 12, 2026

Codecov Report

❌ Patch coverage is 92.85714% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 52.33%. Comparing base (13a6356) to head (6bfb8af).

Files with missing lines Patch % Lines
...kages/eas-cli/src/project/android/applicationId.ts 92.86% 1 Missing ⚠️
...ckages/eas-cli/src/project/ios/bundleIdentifier.ts 92.86% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3399      +/-   ##
==========================================
+ Coverage   52.30%   52.33%   +0.03%     
==========================================
  Files         804      804              
  Lines       33421    33435      +14     
  Branches     6972     6976       +4     
==========================================
+ Hits        17478    17494      +16     
- Misses      14555    15856    +1301     
+ Partials     1388       85    -1303     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant