[infra] Stop preparing tarballs #3361
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Subscribed to pull request
Generated by CodeMention |
|
⏩ The changelog entry check has been skipped since the "no changelog" label is present. |
|
Size Change: -279 kB (-0.49%) Total Size: 56.9 MB
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3361 +/- ##
=======================================
Coverage 49.56% 49.56%
=======================================
Files 675 675
Lines 28511 28511
Branches 5931 5931
=======================================
Hits 14129 14129
Misses 13167 13167
Partials 1215 1215 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
douglowder
requested changes
Jan 30, 2026
Contributor
douglowder
left a comment
douglowder
left a comment
There was a problem hiding this comment.
I'd like to discuss this change a bit before it goes in...
Contributor
Author
|
Sure! |
douglowder
approved these changes
Feb 6, 2026
sjchmiela
added a commit
that referenced
this pull request
Feb 6, 2026
<!-- If this PR requires a changelog entry, add it by commenting the PR with the command `/changelog-entry [breaking-change|new-feature|bug-fix|chore] [message]`. --> <!-- You can skip the changelog check by labeling the PR with "no changelog". --> # Why When oclif is building tarballs with executables it does so in a directory separate from the monorepo which requires us to change `eas-cli` dependencies from the monorepo to `file`. # How Asked Gemini to update the script to include all local dependencies of `eas-cli`. Or… we can land #3361 … # Test Plan Release should pass. Validated locally. (Hmm but on CI it failed? Will see.) Ok, so size failed because it ran on `main` which is broken because it lacks this pull request. <img width="944" height="1031" alt="Zrzut ekranu 2026-02-5 o 19 05 41" src="https://github.com/user-attachments/assets/1134493c-bbdb-4f08-85d6-07e59fa28750" />
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Our GitHub released executable Oclif bundles of
eas-cliare… not too popular. v16.28.0 was downloaded 154k times in the last 7 days from NPM. Since its release (2 months ago) it was downloaded from GitHub 82 times.How
Asked Gemini to remove this. This should speed up release process significantly. This release process has been created 5 years ago (#54).
Also removed size comparison workflow. It's not going to make comments like #3361 (comment).
Closes #3346.
Test Plan
CI should pass.