Skip to content

Conversation

@sjchmiela
Copy link
Contributor

@sjchmiela sjchmiela commented Feb 5, 2026

Why

When oclif is building tarballs with executables it does so in a directory separate from the monorepo which requires us to change eas-cli dependencies from the monorepo to file.

How

Asked Gemini to update the script to include all local dependencies of eas-cli.

Or… we can land #3361

Test Plan

Release should pass. Validated locally. (Hmm but on CI it failed? Will see.)

Ok, so size failed because it ran on main which is broken because it lacks this pull request.

Zrzut ekranu 2026-02-5 o 19 05 41

@github-actions
Copy link

github-actions bot commented Feb 5, 2026

Subscribed to pull request

File Patterns Mentions
**/* @douglowder

Generated by CodeMention

@sjchmiela sjchmiela force-pushed the stanley/fix-pretarball-ci branch from e82a2f7 to ff67d6d Compare February 5, 2026 16:17
@sjchmiela sjchmiela requested a review from douglowder February 5, 2026 16:18
@sjchmiela sjchmiela added the no changelog PR that doesn't require a changelog entry label Feb 5, 2026
@github-actions
Copy link

github-actions bot commented Feb 5, 2026

⏩ The changelog entry check has been skipped since the "no changelog" label is present.

@codecov
Copy link

codecov bot commented Feb 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 52.32%. Comparing base (f68cbb4) to head (f54fbbe).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3381   +/-   ##
=======================================
  Coverage   52.32%   52.32%           
=======================================
  Files         804      804           
  Lines       33411    33411           
  Branches     6968     6968           
=======================================
  Hits        17480    17480           
  Misses      14543    14543           
  Partials     1388     1388           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sjchmiela sjchmiela merged commit 67087e9 into main Feb 6, 2026
10 of 12 checks passed
@sjchmiela sjchmiela deleted the stanley/fix-pretarball-ci branch February 6, 2026 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no changelog PR that doesn't require a changelog entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants