feat: add Hungarian translations#936
Conversation
bsipocz
left a comment
bsipocz
left a comment
There was a problem hiding this comment.
I have a bunch of suggestions, most of the translations look good, but one or two may be off depending on the context. Also, I think we should drop all the : to be more consistent with the other languages, and may also want to have everything capitalized? (I'm not sure about that one).
Also, unrelated nitpick: please don't mix new features with restructuring and other unrelated stylistic changes in the same commit or even in the same PR. It would have been easier to review without all the reordering.
| { "language": "German", "symbol": "de", "text": "Bis zum" }, | ||
| { "language": "Greek", "symbol": "el", "text": "Από το" }, | ||
| { "language": "Hebrew", "symbol": "iw", "text": "דרך" }, | ||
| { "language": "Hungarian", "symbol": "hu", "text": "Szerző:" }, |
There was a problem hiding this comment.
| { "language": "Hungarian", "symbol": "hu", "text": "Szerző:" }, | |
| { "language": "Hungarian", "symbol": "hu", "text": "Szerző" }, |
There was a problem hiding this comment.
This is typical Hungarian. The translatable text is incomplete, it should be "By the COMPANY NAME" or "By the %s", but in Hungary we put the name first and then the rest of the string. Since I have no possibility to change the word order, I have to use : like: "Author:" + COMPANY NAME
| { "language": "German", "symbol": "de", "text": "Durch" }, | ||
| { "language": "Greek", "symbol": "el", "text": "Με" }, | ||
| { "language": "Hebrew", "symbol": "iw", "text": "על ידי" }, | ||
| { "language": "Hungarian", "symbol": "hu", "text": "Szerző:" }, |
There was a problem hiding this comment.
| { "language": "Hungarian", "symbol": "hu", "text": "Szerző:" }, | |
| { "language": "Hungarian", "symbol": "hu", "text": "Szerző" }, |
| { "language": "German", "symbol": "de", "text": "Zuletzt aktualisiert am" }, | ||
| { "language": "Greek", "symbol": "el", "text": "Τελευταία ενημέρωση στις" }, | ||
| { "language": "Hebrew", "symbol": "iw", "text": "עודכן לאחרונה ב" }, | ||
| { "language": "Hungarian", "symbol": "hu", "text": "Utoljára frissítve:" }, |
There was a problem hiding this comment.
| { "language": "Hungarian", "symbol": "hu", "text": "Utoljára frissítve:" }, | |
| { "language": "Hungarian", "symbol": "hu", "text": "Utoljára frissítve" }, |
There was a problem hiding this comment.
Same as above. The source is incomplete, it should be "Last updated on 19/03/2026" or "Last updated on %s", but in Hungarian language I have to put conjugation after the date like "Utoljára frissítve 2026. 03. 18**-án**". Since this is not possible, I have to use : here, too.
| { "language": "German", "symbol": "de", "text": "Nächste Seite" }, | ||
| { "language": "Greek", "symbol": "el", "text": "επόμενη σελίδα" }, | ||
| { "language": "Hebrew", "symbol": "iw", "text": "עמוד הבא" }, | ||
| { "language": "Hungarian", "symbol": "hu", "text": "következő oldal" }, |
There was a problem hiding this comment.
Not sure where this is used, but I think we should capitalize to make it more consistent with the other ones.
| { "language": "Hungarian", "symbol": "hu", "text": "következő oldal" }, | |
| { "language": "Hungarian", "symbol": "hu", "text": "Következő oldal" }, |
There was a problem hiding this comment.
This is the tooltip if you hover the mouse over the "Next page" link. I also prefer Capitalized version, but the source string is "next page", with lowercase first letter. Please fix this first.
| { "language": "German", "symbol": "de", "text": "Öffnen Sie ein Problem" }, | ||
| { "language": "Greek", "symbol": "el", "text": "Ανοίξτε ένα ζήτημα" }, | ||
| { "language": "Hebrew", "symbol": "iw", "text": "פתח גיליון" }, | ||
| { "language": "Hungarian", "symbol": "hu", "text": "Problémajegy nyitása" }, |
There was a problem hiding this comment.
Problémajegy sounds absolutely weird. But if that's the usual translation, then be it.
| { "language": "German", "symbol": "de", "text": "offenes Thema" }, | ||
| { "language": "Greek", "symbol": "el", "text": "ανοιχτό ζήτημα" }, | ||
| { "language": "Hebrew", "symbol": "iw", "text": "בעיה פתוחה" }, | ||
| { "language": "Hungarian", "symbol": "hu", "text": "nyitott probléma" }, |
There was a problem hiding this comment.
I think this should be the same as the previous, I suspect it being used in the "open an issue" context; though maybe we should double check
There was a problem hiding this comment.
The source string is "open issue". I guess, this is also an incomplete source which should be "%d open issue". I cannot decide this without context. Please fix the source string first.
| { "language": "German", "symbol": "de", "text": "Repository" }, | ||
| { "language": "Greek", "symbol": "el", "text": "αποθήκη" }, | ||
| { "language": "Hebrew", "symbol": "iw", "text": "מאגר" }, | ||
| { "language": "Hungarian", "symbol": "hu", "text": "tároló" }, |
There was a problem hiding this comment.
tényleg "github tároló" a magyar forditas?
There was a problem hiding this comment.
Yes, "GitHub repository" is "GitHub-tároló" in Hungarian.
| { "language": "German", "symbol": "de", "text": "Quell-Repository" }, | ||
| { "language": "Greek", "symbol": "el", "text": "Αποθήκη πηγής" }, | ||
| { "language": "Hebrew", "symbol": "iw", "text": "מאגר המקורות" }, | ||
| { "language": "Hungarian", "symbol": "hu", "text": "Forrástároló" }, |
There was a problem hiding this comment.
maybe make it more explicit?
| { "language": "Hungarian", "symbol": "hu", "text": "Forrástároló" }, | |
| { "language": "Hungarian", "symbol": "hu", "text": "Forráskód-tároló" }, |
There was a problem hiding this comment.
Do you know the Hungarian grammar? I mean the official grammar from here? I do, because I am native Hungarian. Trust me, "Forráskódtároló" is the correct form :)
There was a problem hiding this comment.
There is absolutely no need to be insulting. I added kod in there, and now it's a long multi-part compound noun that could use an en dash.
| { "language": "German", "symbol": "de", "text": "Sphinx-Buch-Thema" }, | ||
| { "language": "Greek", "symbol": "el", "text": "Θέμα βιβλίου Sphinx" }, | ||
| { "language": "Hebrew", "symbol": "iw", "text": "נושא ספר ספינקס" }, | ||
| { "language": "Hungarian", "symbol": "hu", "text": "Sphinx könyvtéma" }, |
There was a problem hiding this comment.
nem inkább könyvminta vagy könyvsablon ?
There was a problem hiding this comment.
I translated the source string, which is "Sphinx Book Theme". Book theme is "könyvtéma" in Hungarian. If you prefer "minta" or "sablon", please change the source accordingly to "pattern" or "template".
There was a problem hiding this comment.
No need to go with the first dictionary meaning of the word but find the one that best describe the meaning. The theme is really a minta/sablon/vázlat for the styling in this case and not to be confused with téma which to me suggests to be about the actual content of the book.
| { "language": "German", "symbol": "de", "text": "Thema von der" }, | ||
| { "language": "Greek", "symbol": "el", "text": "Θέμα από το" }, | ||
| { "language": "Hebrew", "symbol": "iw", "text": "נושא מאת" }, | ||
| { "language": "Hungarian", "symbol": "hu", "text": "Téma készítője:" }, |
There was a problem hiding this comment.
| { "language": "Hungarian", "symbol": "hu", "text": "Téma készítője:" }, | |
| { "language": "Hungarian", "symbol": "hu", "text": "Téma készítője" }, |
|
So, can you accept this PR as is, or shall I modify it by adding Hungarian translations to the end of the list? |
|
You can insert the Hungarian into the roughly correct alphabetical location or to the end. The point is to not mix in unrelated reorganisations. If your editor reorders/restyles everything automatically, then you can selectively add only the Hungarian lines. Now it's already done and reviewed, so it's more about future open source contributions. |
2 participants
Added Hungarian translations and sorted existing translations in alphabetical order.