test(mail): characterize production email contracts - #2526
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 18157c9300
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d64336d454
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5b6a0805ea
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2c4d518c2d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| private static string BuildMailtoHref(string emailAddress, string? body) | ||
| { | ||
| string href = $"mailto:{Uri.EscapeDataString(emailAddress)}"; |
There was a problem hiding this comment.
Preserve the @ delimiter in mailto links
For every event notice containing a user email address, Uri.EscapeDataString(emailAddress) escapes the structural @ as %40, producing links such as mailto:victim%40example.com. A mailto recipient is an addr-spec whose separator must remain literal, and clients that do not decode the entire scheme-specific address before parsing can reject it or treat it as an invalid recipient. Encode unsafe address components without escaping the @ delimiter, while continuing to encode the query-body value.
Useful? React with 👍 / 👎.
Summary
Verification
Post-Deploy Monitoring & Validation
No additional operational monitoring is required because this PR changes tests only; production email code and rendered output are unchanged.