fix(mail): safely render event links and regression labels - #2527
fix(mail): safely render event links and regression labels#2527niemyjski wants to merge 1 commit into
Conversation
ad0a5d7 to
22ba2ac
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 22ba2ac860
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| private static string BuildMailtoHref(string emailAddress, string? body) | ||
| { | ||
| string href = $"mailto:{Uri.EscapeDataString(emailAddress)}"; |
There was a problem hiding this comment.
Uri.EscapeDataString(emailAddress) also escapes the structural @, producing links such as mailto:victim%40example.com. The mailto URI grammar requires a literal @ between the local part and domain, so strict mail handlers can treat every generated recipient as malformed or leave the recipient blank. Encode the address components while preserving the delimiter, and continue encoding the body separately.
Useful? React with 👍 / 👎.
22ba2ac to
3b9a74e
Compare
|
1 participant
Summary
This is stacked on #2526 so the production changes are reviewable separately from the characterization suite.
Verification
Post-Deploy Monitoring & Validation
After deployment, verify one event-notice email containing a user description opens a prefilled mail client without creating additional recipient headers, and verify regressed/non-regressed daily-summary rows display the label only for regressed stacks.