Launching another Enso process via Process_Builder#14753
Merged
mergify[bot] merged 17 commits intodevelopfrom Feb 16, 2026
Merged
Launching another Enso process via Process_Builder#14753mergify[bot] merged 17 commits intodevelopfrom
Process_Builder#14753mergify[bot] merged 17 commits intodevelopfrom
Conversation
JaroslavTulach
requested review from
AdRiley,
hubertp and
jdunkerley
as code owners
github-actions
Bot
added
the
-libs-API-change-Base
Member
Author
|
jdunkerley
approved these changes
Feb 11, 2026
JaroslavTulach
commented
Feb 11, 2026
| out = J_String.new bytes | ||
| if retcode != 0 then | ||
| proc_bldr = Process.enso_builder args | ||
| # proc_bldr.directory (J_File.new cwd) |
Member
Author
There was a problem hiding this comment.
- I will have to update the
Process_Builderto support setting current working directory - without it the Enso Runner tests won't pass
- done in 4602dd9
jdunkerley
approved these changes
Feb 12, 2026
Co-authored-by: James Dunkerley <jdunkerley@users.noreply.github.com>
Co-authored-by: James Dunkerley <jdunkerley@users.noreply.github.com>
4e6
approved these changes
Feb 13, 2026
JaroslavTulach
added
the
CI: Ready to merge
JaroslavTulach
commented
Feb 16, 2026
| | | ||
| |main = | ||
| | result = System.create_process "echo" [] "" False False False | ||
| | result = System.create_process "echo" [] "" False False False Nothing |
Member
Author
There was a problem hiding this comment.
- there is 6th in a row failure on Windows
- but clearly
Nothingis imported here! - trying to execute again with a manual CI clean
- as 9eb5d55 shows restarting would never solved the problem
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Process_Builder"enso"Enso_Bin_Utilsinstead of home madetest/Base_TestssolutionImportant Notes
new_builder"enso"command seems simplerPATHenvironment variable include the Enso bin directoryChecklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Java,