Launching another Enso process via Process_Builder (#14753)

- make it easy to launch another Enso process via `Process_Builder`
- just say the command to execute is `"enso"`
- we'll make sure we find it for you!
- internally we use the new method in `Enso_Bin_Utils` instead of home made `test/Base_Tests` solution

# Important Notes
- original version was proposing alternative method to `new_builder`
- however just recognizing `"enso"` command seems simpler
- and it is kind of natural - just like making sure that `PATH` environment variable include the Enso bin directory
- something I have done recently for NetBeans: apache/netbeans#8756

Author: JaroslavTulach

CHANGELOG.md

@@ -20,6 +20,7 @@
 - [Add Amazon SES email provider][14597]
 - [Support for reading Alteryx YXDB files][14602].
 - [Salesforce OAuth support.][14550]
+- [Launching another Enso process via `Process_Builder`][14753]
 - [Redshift schema support.][14735]
 
 [14522]: https://github.com/enso-org/enso/pull/14522
@@ -31,6 +32,7 @@
 [14597]: https://github.com/enso-org/enso/pull/14597
 [14602]: https://github.com/enso-org/enso/pull/14602
 [14550]: https://github.com/enso-org/enso/pull/14550
+[14753]: https://github.com/enso-org/enso/pull/14753
 [14735]: https://github.com/enso-org/enso/pull/14735
 
 #### Enso Language & Runtime

distribution/lib/Standard/Base/0.0.0-dev/docs/api/System/Process.md

@@ -1,4 +1,4 @@
 ## Enso Signatures 1.0
 ## module Standard.Base.System.Process
-- new_builder command:Standard.Base.Any.Any arguments:Standard.Base.Any.Any= stdin:Standard.Base.Any.Any= -> Standard.Base.Any.Any
+- new_builder command:Standard.Base.Data.Text.Text arguments:Standard.Base.Any.Any= stdin:Standard.Base.Any.Any= -> Standard.Base.System.Process.Process_Builder.Process_Builder
 - run command:Standard.Base.Data.Text.Text arguments:Standard.Base.Any.Any= stdin:Standard.Base.Data.Text.Text= redirect_out_err:Standard.Base.Data.Boolean.Boolean= -> Standard.Base.Any.Any

distribution/lib/Standard/Base/0.0.0-dev/docs/api/System/Process/Process_Builder.md

@@ -1,10 +1,11 @@
 ## Enso Signatures 1.0
 ## module Standard.Base.System.Process.Process_Builder
 - type Process_Builder
-    - Value command:Standard.Base.Any.Any arguments:Standard.Base.Any.Any stdin:Standard.Base.Any.Any
-    - create self redirect_out_err:Standard.Base.Data.Boolean.Boolean= -> Standard.Base.Any.Any
-    - set_arguments self arguments:Standard.Base.Any.Any -> Standard.Base.Any.Any
-    - set_stdin self stdin:Standard.Base.Any.Any -> Standard.Base.Any.Any
+    - create self redirect_out_err:Standard.Base.Data.Boolean.Boolean= -> Standard.Base.System.Process.Process_Builder.Process_Result
+    - set_arguments self arguments:(Standard.Base.Data.Vector.Vector Standard.Base.Data.Text.Text) -> Standard.Base.System.Process.Process_Builder.Process_Builder
+    - set_directory self path:Standard.Base.System.File.File -> Standard.Base.System.Process.Process_Builder.Process_Builder
+    - set_stdin self stdin:Standard.Base.Data.Text.Text -> Standard.Base.System.Process.Process_Builder.Process_Builder
+    - to_js_object self -> Standard.Base.Data.Json.JS_Object
 - type Process_Result
     - Value exit_code:Standard.Base.System.Process.Exit_Code.Exit_Code stdout:Standard.Base.Data.Text.Text stderr:Standard.Base.Data.Text.Text
-    - to_display_text self -> Standard.Base.Any.Any
+    - to_display_text self -> Standard.Base.Data.Text.Text

distribution/lib/Standard/Base/0.0.0-dev/src/Internal/Runtime_Helpers.enso

@@ -48,3 +48,5 @@ state_uninitialized key =
 ref_new ~value = @Builtin_Method "Ref.alloc"
 ref_get ref = @Builtin_Method "Ref.get"
 ref_put ref new_value = @Builtin_Method "Ref.put"
+
+create_process command arguments input redirect_in redirect_out redirect_err cwd = @Builtin_Method "System.create_process"

distribution/lib/Standard/Base/0.0.0-dev/src/System.enso

@@ -5,6 +5,7 @@ import project.Data.Boolean.Boolean
 import project.Data.Numbers.Integer
 import project.Data.Text.Text
 import project.Nothing.Nothing
+import project.Internal.Runtime_Helpers
 
 polyglot java import java.lang.System as Java_System
 
@@ -25,7 +26,8 @@ polyglot java import java.lang.System as Java_System
     - `redirect_err`: Specifies if the standard error output of the started
       process should be redirected to the program's standard error output.
 create_process : Text -> Array -> Text -> Boolean -> Boolean -> Boolean -> System_Process_Result
-create_process command arguments input redirect_in redirect_out redirect_err = @Builtin_Method "System.create_process"
+create_process command arguments input redirect_in redirect_out redirect_err =
+    Runtime_Helpers.create_process command arguments input redirect_in redirect_out redirect_err Nothing
 
 ## ---
    private: true

distribution/lib/Standard/Base/0.0.0-dev/src/System/Process.enso

@@ -1,10 +1,13 @@
 import project.Data.Text.Text
 import project.Data.Vector.Vector
+import project.Nothing.Nothing
 import project.System.Process.Process_Builder.Process_Builder
 import project.System.Process.Process_Builder.Process_Result
 from project.Data.Boolean import Boolean, False
 from project.Metadata.Widget import Text_Input, Vector_Editor
 
+polyglot java import org.enso.base.file_system.File_Utils
+
 ## ---
    aliases: [run a command]
    group: System
@@ -44,7 +47,6 @@ run command:Text arguments=[] stdin:Text="" redirect_out_err:Boolean=False =
     - `command`: The command to execute on the system.
     - `arguments`: The arguments to pass to `command`. These must be text.
     - `stdin`: Any content to pass to the standard input for `command`.
-    - `redirect_out_err`: Redirect stdout/stderr to `Process_Result`.
 
    ## Examples
    ### Create a new builder for a command "echo".
@@ -54,5 +56,10 @@ run command:Text arguments=[] stdin:Text="" redirect_out_err:Boolean=False =
 
          example_new_builder = Process.new_builder "echo"
    ```
-new_builder : Text -> Vector Text -> Text -> Process_Builder
-new_builder command arguments=[] stdin="" = Process_Builder.Value command arguments stdin
+new_builder command:Text arguments=[]:(Vector Text) stdin="":Text -> Process_Builder =
+   cmd =
+      if command == "enso" then
+         File_Utils.getExecutableLocation
+      else
+         command
+   Process_Builder.Value cmd arguments stdin Nothing

distribution/lib/Standard/Base/0.0.0-dev/src/System/Process/Process_Builder.enso

@@ -1,6 +1,9 @@
+import project.Data.Json.JS_Object
 import project.Data.Text.Text
 import project.Data.Vector.Vector
-import project.System
+import project.Nothing.Nothing
+import project.Internal.Runtime_Helpers
+import project.System.File.File
 import project.System.Process.Exit_Code.Exit_Code
 from project.Data.Boolean import Boolean, False
 
@@ -26,7 +29,7 @@ type Process_Builder
        We recommend that you use this type with its builder interface. Start by
        creating a `Builder "command"` and then call functions on it to set
        arguments and standard output. It results in much clearer code.
-    Value command arguments stdin
+    private Value command:Text (arguments:(Vector Text)) stdin:Text (cwd:Nothing|File)
 
     ## ---
        icon: edit
@@ -46,8 +49,8 @@ type Process_Builder
                  builder = Process.new_builder "echo"
                  builder.set_arguments ["hello, world!"]
        ```
-    set_arguments : Vector Text -> Process_Builder
-    set_arguments self arguments = Process_Builder.Value self.command arguments self.stdin
+    set_arguments self (arguments:Vector Text) -> Process_Builder =
+        Process_Builder.Value self.command arguments self.stdin self.cwd
 
     ## ---
        icon: edit
@@ -68,8 +71,18 @@ type Process_Builder
                  builder = Process.new_builder "echo"
                  builder.set_stdin "hello, world!"
        ```
-    set_stdin : Text -> Process_Builder
-    set_stdin self stdin = Process_Builder.Value self.command self.arguments stdin
+    set_stdin self stdin:Text -> Process_Builder = Process_Builder.Value self.command self.arguments stdin self.cwd
+
+    ## ---
+       icon: edit
+       ---
+       Sets the directory to execute the process at
+
+       ## Arguments
+        - `path`: the directory to execute the process at
+
+    set_directory self path:File -> Process_Builder =
+        Process_Builder.Value self.command self.arguments self.stdin path
 
     ## ---
        icon: system
@@ -90,12 +103,18 @@ type Process_Builder
                  with_args = builder.set_arguments ["hello, world!"]
                  with_args.create
        ```
-    create : Boolean -> Process_Result
-    create self redirect_out_err:Boolean=False =
-        result = System.create_process self.command self.arguments self.stdin redirect_in=(self.stdin == False) redirect_out=redirect_out_err redirect_err=redirect_out_err
+    create self redirect_out_err:Boolean=False -> Process_Result =
+        cwd = if self.cwd != Nothing then
+            self.cwd.to_text
+        result = Runtime_Helpers.create_process self.command self.arguments self.stdin redirect_in=(self.stdin == False) redirect_out=redirect_out_err redirect_err=redirect_out_err cwd
         exit_code = Exit_Code.from_number result.exit_code
         Process_Result.Value exit_code result.stdout result.stderr
 
+    ## ---
+       private: true
+       ---
+    to_js_object self -> JS_Object = JS_Object.from_pairs [["type", "Process_Builder"]]
+
 type Process_Result
     ## ---
        private: true
@@ -106,7 +125,6 @@ type Process_Result
        private: true
        ---
        Convert to a display representation of this Process_Result.
-    to_display_text : Text
-    to_display_text self = case self.exit_code of
+    to_display_text self -> Text = case self.exit_code of
         Exit_Code.Success -> "Success(" + self.stdout.to_display_text + ")"
         _ -> self.exit_code.to_display_text + "(" + self.stderr.to_display_text + ")"