-
Notifications
You must be signed in to change notification settings - Fork 390
Add health component #2373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+67
−24
Merged
Add health component #2373
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
d1c2490
Add health component
Litraxx b9c60b2
Refactor fragile barrel to use health component
Litraxx e9c816f
Adjust `current_health` setter logic
Litraxx d957585
Adjust signal connection to health component
Litraxx b5ba79a
Update current_health setter logic
Litraxx 3812bf9
Rename damage_taken_percentage to align with godot convention
Litraxx df934ab
Add code documentation to signals and current_health
Litraxx 1e852af
Rename take_damage function to reflect new behaviour
Litraxx dfcee69
Update member reference
Litraxx 0676869
Update documentation of signal
Litraxx ebef24b
HealthComponent: Change base type to Node
wjt 7f2fa8c
FragileBarrel: Rename health_depleted callback
wjt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| # SPDX-FileCopyrightText: The Threadbare Authors | ||
| # SPDX-License-Identifier: MPL-2.0 | ||
| class_name HealthComponent | ||
| extends Node | ||
|
|
||
| ## Emitted when [member current_health] reaches zero. | ||
| signal health_depleted | ||
|
|
||
| ## Emitted when [member current_health] changes.[br] | ||
| ## Is not emitted when the health reaches zero, [signal health_depleted] is emitted instead. | ||
| signal health_changed(current_health: int) | ||
|
|
||
| @export_range(1, 100) var max_health: int = 4 | ||
|
|
||
| ## Represents the current health.[br] | ||
| ## The value will always be in the following range [code]0 <= current_health <= max_health[/code]. | ||
| var current_health: int = max_health: | ||
| set(value): | ||
| if value == current_health: | ||
| return | ||
|
|
||
| current_health = clamp(value, 0, max_health) | ||
| if current_health <= 0: | ||
| health_depleted.emit() | ||
| else: | ||
| health_changed.emit(current_health) | ||
|
|
||
| var damage_taken: int: | ||
| get: | ||
| return max_health - current_health | ||
|
|
||
| var damage_taken_ratio: float: | ||
| get: | ||
| return float(damage_taken) / max_health | ||
|
|
||
| var has_depleted_health: bool: | ||
| get: | ||
| return current_health <= 0 | ||
|
|
||
|
|
||
| func damage(amount: int) -> void: | ||
| current_health -= amount | ||
|
|
||
|
|
||
| func heal(amount: int) -> void: | ||
| current_health += amount | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| uid://b0qrfv6upnqtu |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.