Add health component#2373
Merged
Merged
Conversation
Changed break_barrel and take_damage functions to be called by health component signals Replaced existing health logic with health component
This should make the setter more readable Also removed the redundant `has_depleted_health` signal argument
The check is not needed since the signal is only ever called when the health change does not deplete the health
|
Test build no longer available. |
wjt
requested changes
Jun 15, 2026
wjt
left a comment
wjt
left a comment
Member
There was a problem hiding this comment.
Great start, thank you for working on this!
Added a clamp to the current_health to avoid unexpected values in other members
This component does not need a position in 2D space.
wjt
approved these changes
Jun 16, 2026
wjt
left a comment
wjt
left a comment
Member
There was a problem hiding this comment.
Thanks! I added a couple of tiny changes for things I only spotted while re-reviewing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a generic health component that can be reused in different scenes.
It exports a max health property and provides various properties regarding health status.
It also provides two signals
health_depletedemitted when a change to the current health pushes it to zero or belowhealth_changedemitted when the health is changed and the change does not cause the health to deplete; emits the current health as an argumentRefactored the fragile barrel to use the new health component
Resolves #1747