Skip to content

[pylauncher] Add VERSIONINFO resource file for Windows launcher #27601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sbc100 wants to merge 1 commit into
base: main
Choose a base branch
from
+43 −1
Open

[pylauncher] Add VERSIONINFO resource file for Windows launcher #27601

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ coverage.xml
!/tools/run_python_compiler.ps1

/tools/pylauncher/*.obj
/tools/pylauncher/*.res

# Shell scripts (created by ./tools/maint/create_entry_points.py)
em++
Expand Down
3 changes: 2 additions & 1 deletion tools/pylauncher/build.bat
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,4 +19,5 @@ if /i "%~1"=="arm64" (
set MACHINE=ARM64
)

cl pylauncher.c /Fe:%OUT% /O1 /GS- /link /NODEFAULTLIB /ENTRY:launcher_main /SUBSYSTEM:CONSOLE /MACHINE:%MACHINE% /Brepro ucrt.lib kernel32.lib
rc /nologo /fo pylauncher.res pylauncher.rc
cl pylauncher.c pylauncher.res /Fe:%OUT% /O1 /GS- /link /NODEFAULTLIB /ENTRY:launcher_main /SUBSYSTEM:CONSOLE /MACHINE:%MACHINE% /Brepro ucrt.lib kernel32.lib
Binary file modified tools/pylauncher/pylauncher-arm64.exe
View file
Open in desktop
Binary file not shown.
Binary file modified tools/pylauncher/pylauncher.exe
View file
Open in desktop
Binary file not shown.
40 changes: 40 additions & 0 deletions tools/pylauncher/pylauncher.rc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
#include <winres.h>

#define VER_FILEVERSION 1,0,0,0
#define VER_FILEVERSION_STR "1.0.0.0"

#define VER_PRODUCTVERSION 1,0,0,0
#define VER_PRODUCTVERSION_STR "1.0.0.0"

@dschuff dschuff Aug 25, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we somehow get the real version in here?


1 VERSIONINFO
FILEVERSION VER_FILEVERSION
PRODUCTVERSION VER_PRODUCTVERSION
FILEFLAGSMASK VS_FFI_FILEFLAGSMASK
#ifdef _DEBUG
FILEFLAGS VS_FF_DEBUG
#else
FILEFLAGS 0x0L
#endif
FILEOS VOS_NT_WINDOWS32
FILETYPE VFT_APP
FILESUBTYPE VFT2_UNKNOWN
BEGIN
BLOCK "StringFileInfo"
BEGIN
BLOCK "040904b0"
BEGIN
VALUE "CompanyName", "The Emscripten Authors"
VALUE "FileDescription", "Emscripten Python Launcher"
VALUE "FileVersion", VER_FILEVERSION_STR
VALUE "InternalName", "pylauncher"
VALUE "LegalCopyright", "Copyright (c) The Emscripten Authors"
VALUE "OriginalFilename", "pylauncher.exe"
VALUE "ProductName", "Emscripten"
VALUE "ProductVersion", VER_PRODUCTVERSION_STR
END
END
BLOCK "VarFileInfo"
BEGIN
VALUE "Translation", 0x0409, 1200
END
END
Loading