[pylauncher] Add VERSIONINFO resource file for Windows launcher - #27601
[pylauncher] Add VERSIONINFO resource file for Windows launcher#27601sbc100 wants to merge 1 commit into
Conversation
cf84def to
0682f54
Compare
Add `tools/pylauncher/pylauncher.rc` containing a `VERSIONINFO` resource with metadata (file description, version, copyright, company) and update `build.bat` to compile it with `rc.exe` and link it into `pylauncher.exe`. This helps properly identify the executable in Windows and reduces generic heuristic false positive detections from antivirus scanners.
|
Followup change if this doesn't work sbc100#2 |
| #define VER_FILEVERSION_STR "1.0.0.0" | ||
|
|
||
| #define VER_PRODUCTVERSION 1,0,0,0 | ||
| #define VER_PRODUCTVERSION_STR "1.0.0.0" |
There was a problem hiding this comment.
can we somehow get the real version in here?
|
Should we have this for Binaryen? Why is it not triggering the same issues? |
If you install the prebuilt binaries you get the one from emscripten-releases that is built each release. |
No idea. We are kind shooting in the dark here because the malware checkers are opaque and heuristic-based in some cases AFAICT. I'm just going down the list of "things that can look suspicious to malware checkers" and checking them off. Then next one is sbc100#2, but I don't really have any way to check they work other than ask users of Norton. I can upload the executables to scanning websites, but even clang.exe that we have been shipping forever is not completely clean when I upload it to the VirusTotal site. |
2 participants
Add
tools/pylauncher/pylauncher.rccontaining aVERSIONINFOresource with metadata (file description, version, copyright, company) and updatebuild.batto compile it withrc.exeand link it intopylauncher.exe.This helps properly identify the executable in Windows and reduces generic heuristic false positive detections from antivirus scanners.