WIP: Manage series stack#1618
Closed
owi92 wants to merge 5 commits intoelan-ev:mainfrom
Closed
Conversation
This was an inline union type before that was used for both series and videos, and soon to be used for playlists. Creating a type for that just made sense (in my mind).
This button not shown in a regular realm context, but only in series blocks on single series pages. That somewhat mirrors what we do with video blocks. Putting it everywhere would clutter up the UI. On the other hand, this might not achieve the desired effect of making it easier to get to that manage page in the first place. So maybe it should actually be shown in every context, but only for people with write access.
This was getting out of hand. There is no great solution, but batching some props to later destcructure them seems ok and increases readability at least a little.
And also show that button on every block if the conditions allow (see the other commit message for reasoning). Also removes that other condition (`isSingleItemPage`) or rather the function that returns the condition. It wasn't used anyway (guess that got lost in some edit again.... gotta pay more attention when using `ctrl + z`).
Member
Author
|
There was no feedback on this, but I think it's fine. I moved to commit over to #1616 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
alternative proposition to #1616