Skip to content

Add manage button to series blocks#1616

Merged
LukasKalbertodt merged 7 commits intoelan-ev:mainfrom
owi92:series-manage-button
Jan 14, 2026
Merged

Add manage button to series blocks#1616
LukasKalbertodt merged 7 commits intoelan-ev:mainfrom
owi92:series-manage-button

Conversation

@owi92
Copy link
Copy Markdown
Member

@owi92 owi92 commented Dec 3, 2025

This buttons links directly to the "series details" page. I was considering to only add it to dedicated series pages, but that kinda defeats the purpose of getting there more easily.
The button is only shown if you have write access for that series.

Also includes some refactoring of semi-related code.
To review, probably just ignore individual commits (maybe read the messages tho).

Closes #1594

@owi92 owi92 added the changelog:user User facing changes label Dec 3, 2025
@github-actions github-actions Bot temporarily deployed to test-deployment-pr1616 December 3, 2025 16:21 Destroyed
@dagraf
Copy link
Copy Markdown
Collaborator

dagraf commented Dec 4, 2025

Thanks for adding the button. I think, we/you should invest some effort in improving the display of series (especially for smaller screens). What I observed and consider suboptimal:

  1. On smaller screens (not on mobile devices) and when metadata is not shown, the buttons stay on the same line but the title is spread across several lines.
Bildschirmfoto 2025-12-04 um 08 19 54
  1. On smaller screens, when metadata is shown and only in editing-mode, the button to the far right exits the window.
Bildschirmfoto 2025-12-04 um 08 21 39
  1. When metadata is shown, the buttons are displayed to the right of the description. I would prefer them to be in the upper right corner, next to the title. But that's not a strong opinion.

@owi92 owi92 marked this pull request as draft December 4, 2025 17:00
@owi92 owi92 mentioned this pull request Dec 4, 2025
@owi92
Copy link
Copy Markdown
Member Author

owi92 commented Dec 4, 2025

Thank you for testing, David.

This turned out to be more tricky than expected (which is weird because it looks pretty trivial). I made another proposition in #1618, which fixes the issues that you have observed and moves the buttons to the top. I also removed the "share" and "manage" text, as these should be pretty much understandable without text. That allows some more room for title and decription.
However that is still not perfect and needs some more work if we decide to take that route.

I am also still leaning towards keeping the buttons on the bottom.
It should be noted that the new "manage" button will rarely be seen by regular students, since I do not expect them to have write access to many (if any) series.
I supspect we won't have the time, but if we do, let's briefly talk about this in our next meeting.

@owi92 owi92 force-pushed the series-manage-button branch from 0756ade to 61aa086 Compare January 12, 2026 11:15
@owi92 owi92 marked this pull request as ready for review January 12, 2026 11:16
@github-actions github-actions Bot temporarily deployed to test-deployment-pr1616 January 12, 2026 11:20 Destroyed
Copy link
Copy Markdown
Member

@LukasKalbertodt LukasKalbertodt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good to me! I'm fine with omitting the label for those two buttons -- the share button was quite prominent before, it's probably better if it is a bit calmer now.

Regarding the "small screen" problem: I agree with Ole in that I prefer the "buttons below" version, i.e. what we had and what this PR keeps. This PR does rewrite the layout logic for all these elements tho. And while I didn't dig deep into the CSS code, from playing around with the test deployment, it seems that it works well in every scenario! So from my perspective we can keep it like that. I also like the gap reduction from 16 to 8.

Yeah I think that's all my thoughts.

Comment thread frontend/src/ui/Blocks/Playlist.tsx Outdated
Comment thread frontend/src/ui/ShareButton.tsx Outdated
Comment thread frontend/src/i18n/locales/en.yaml Outdated
Comment thread frontend/src/ui/Blocks/VideoList.tsx Outdated
Comment thread frontend/src/ui/Blocks/VideoList.tsx Outdated
Comment thread frontend/src/ui/Blocks/VideoList.tsx Outdated
@owi92 owi92 force-pushed the series-manage-button branch from 61aa086 to 44524ab Compare January 13, 2026 15:59
@github-actions github-actions Bot temporarily deployed to test-deployment-pr1616 January 13, 2026 16:04 Destroyed
Comment thread frontend/src/i18n/locales/de.yaml
@owi92 owi92 force-pushed the series-manage-button branch from 44524ab to 47bff4d Compare January 13, 2026 16:44
@github-actions github-actions Bot temporarily deployed to test-deployment-pr1616 January 13, 2026 16:49 Destroyed
@github-actions github-actions Bot added the status:conflicts This PR has conflicts that need to be resolved label Jan 13, 2026
@github-actions

This comment was marked as resolved.

@LukasKalbertodt LukasKalbertodt added this to the v3.12 milestone Jan 13, 2026
owi92 added 2 commits January 14, 2026 11:46
This was an inline union type before that was used for both series and videos,
and soon to be used for playlists.
Creating a type for that made sense to me.
This button isn't shown in a regular realm context,
but only in series blocks on single series pages.
That somewhat mirrors what we do with video blocks.
Putting it everywhere might clutter up the UI.

On the other hand, this might not achieve the desired
effect of making it easier to get to that manage page
in the first place. So maybe it should actually be shown
in every context, but only for people with write access.
@owi92 owi92 force-pushed the series-manage-button branch from 47bff4d to 892fcca Compare January 14, 2026 10:46
@github-actions github-actions Bot removed the status:conflicts This PR has conflicts that need to be resolved label Jan 14, 2026
owi92 added 4 commits January 14, 2026 11:52
This was getting out of hand. There is no great solution, but batching
some props to later destructure them seems ok and increases readability
at least a little.
And also show that button on every block if the
conditions allow (see the other commit message for
reasoning).

Also removes that other condition (`isSingleItemPage`)
or rather the function that returns the condition.
It wasn't used anyway (guess that got lost in some edit
again).
Insert 'css is awesome' meme.
To reflect the fact that share and manage
buttons can be used in different contexts.
This adds a few translations that are yet
unused but included for completeness.
I suspect we'll use them soon.
@owi92 owi92 force-pushed the series-manage-button branch from 892fcca to dbba610 Compare January 14, 2026 10:54
@github-actions github-actions Bot temporarily deployed to test-deployment-pr1616 January 14, 2026 10:57 Destroyed
@owi92 owi92 added this to Tobira Jan 14, 2026
@owi92 owi92 moved this to In Review 👀 in Tobira Jan 14, 2026
@github-actions github-actions Bot temporarily deployed to test-deployment-pr1616 January 14, 2026 16:27 Destroyed
@LukasKalbertodt LukasKalbertodt merged commit f121e80 into elan-ev:main Jan 14, 2026
3 checks passed
@github-project-automation github-project-automation Bot moved this from In Review 👀 to Done ✔️ in Tobira Jan 14, 2026
@owi92 owi92 deleted the series-manage-button branch January 14, 2026 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog:user User facing changes

Projects

Status: Done ✔️

Development

Successfully merging this pull request may close these issues.

Show a "manage" Button on the series overview page (like the "manage" button on the video page)

3 participants