Add manage button to series blocks#1616
Conversation
|
Thank you for testing, David. This turned out to be more tricky than expected (which is weird because it looks pretty trivial). I made another proposition in #1618, which fixes the issues that you have observed and moves the buttons to the top. I also removed the "share" and "manage" text, as these should be pretty much understandable without text. That allows some more room for title and decription. I am also still leaning towards keeping the buttons on the bottom. |
0756ade to
61aa086
Compare
LukasKalbertodt
left a comment
There was a problem hiding this comment.
Generally looks good to me! I'm fine with omitting the label for those two buttons -- the share button was quite prominent before, it's probably better if it is a bit calmer now.
Regarding the "small screen" problem: I agree with Ole in that I prefer the "buttons below" version, i.e. what we had and what this PR keeps. This PR does rewrite the layout logic for all these elements tho. And while I didn't dig deep into the CSS code, from playing around with the test deployment, it seems that it works well in every scenario! So from my perspective we can keep it like that. I also like the gap reduction from 16 to 8.
Yeah I think that's all my thoughts.
61aa086 to
44524ab
Compare
44524ab to
47bff4d
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This was an inline union type before that was used for both series and videos, and soon to be used for playlists. Creating a type for that made sense to me.
This button isn't shown in a regular realm context, but only in series blocks on single series pages. That somewhat mirrors what we do with video blocks. Putting it everywhere might clutter up the UI. On the other hand, this might not achieve the desired effect of making it easier to get to that manage page in the first place. So maybe it should actually be shown in every context, but only for people with write access.
47bff4d to
892fcca
Compare
This was getting out of hand. There is no great solution, but batching some props to later destructure them seems ok and increases readability at least a little.
And also show that button on every block if the conditions allow (see the other commit message for reasoning). Also removes that other condition (`isSingleItemPage`) or rather the function that returns the condition. It wasn't used anyway (guess that got lost in some edit again).
Insert 'css is awesome' meme.
To reflect the fact that share and manage buttons can be used in different contexts. This adds a few translations that are yet unused but included for completeness. I suspect we'll use them soon.
892fcca to
dbba610
Compare
9549d80 to
1ee8cf8
Compare


This buttons links directly to the "series details" page. I was considering to only add it to dedicated series pages, but that kinda defeats the purpose of getting there more easily.
The button is only shown if you have write access for that series.
Also includes some refactoring of semi-related code.
To review, probably just ignore individual commits (maybe read the messages tho).
Closes #1594