-
Notifications
You must be signed in to change notification settings - Fork 0
Improve module dropdown #95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| rules: | ||
| - id: module-description-length | ||
| languages: [generic] | ||
| paths: | ||
| include: | ||
| - "services/ws-modules/*/Cargo.toml" | ||
| - "services/ws-modules/*/pyproject.toml" | ||
| - "services/ws-modules/*/build.zig.zon" | ||
| - "services/ws-modules/*/pkg/package.json" | ||
| # Enforce ws-module description length at the source manifests, not by trimming labels in the browser. | ||
| # A ws-module description is the module-dropdown label on the ws-server index page. Two regex alternatives | ||
| # cover the syntaxes the description travels through: `description = "..."` (Cargo.toml / pyproject.toml, | ||
| # and build.zig.zon's `.description = "..."` which the same pattern matches) and `"description": "..."` | ||
| # (the hand-committed pkg/package.json files of the dart / dotnet / java / R modules). The generated | ||
| # pkg/package.json files are gitignored and semgrep scans only tracked files, so the manifest patterns are | ||
| # the ones that matter for generated modules. | ||
| pattern-either: | ||
| - pattern-regex: 'description = "[^"]{41,}"' | ||
| - pattern-regex: '"description": "[^"]{41,}"' | ||
| message: >- | ||
| A ws-module description is the module-dropdown label on the ws-server index page; keep it at most 40 | ||
| characters so the dropdown stays readable. | ||
| severity: ERROR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| [project] | ||
| description = "Python smoke test (RustPython WASM)" | ||
| license = "Apache-2.0 OR MIT" | ||
| name = "et-ws-pywasm1" | ||
| requires-python = ">=3.10" | ||
| version = "0.1.0" | ||
|
|
||
| # No [build-system]: nothing is wheel-built here. | ||
| # The module ships main.py verbatim next to the prebuilt rustpython_wasm artifacts its build task copies into | ||
| # pkg/; this manifest exists so `et-cli module-package-json` derives pkg/package.json from statically | ||
| # checkable input like every other module. | ||
| [tool.ws-module] | ||
| main = "index.js" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🩺 Stability & Availability | 🟠 Major | ⚡ Quick win
Quote the et-cli executable path.
vars.et_cliexpands to an absolute path based onconfig_root_fwd. If the checkout path contains spaces, Bash splits the path and the task fails beforemodule-package-jsonruns.Proposed fix
As per coding guidelines, Windows is a first-tier supported platform.
📝 Committable suggestion
🤖 Prompt for AI Agents
Source: Coding guidelines