Improve module dropdown#95
Conversation
📝 WalkthroughWalkthroughModule metadata was shortened and a Semgrep rule now enforces description length. pywasm1 packaging delegates package.json generation to et-cli, while the ws-server dropdown filters modules by naming convention. ChangesModule metadata and discovery
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.mise/config.toml:
- Line 1499: Quote the vars.et_cli expansion in the module-package-json command
so paths containing spaces remain a single executable argument. Preserve the
existing command and subcommand while ensuring Bash receives the full et-cli
path on all supported platforms.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: f02a3229-d4c3-4b69-aded-f1cbff1539a4
📒 Files selected for processing (10)
.mise/config.tomlconfig/semgrep/module-description-length.yamlservices/ws-modules/pyeye1/pyproject.tomlservices/ws-modules/pywasm1/pyproject.tomlservices/ws-modules/wasi-comm1/Cargo.tomlservices/ws-modules/wasi-data1/Cargo.tomlservices/ws-modules/wasi-graphics-info/pyproject.tomlservices/ws-modules/zig-data1/build.zig.zonservices/ws-modules/zig-except1/build.zig.zonservices/ws-server/static/app.js
| ] | ||
| } | ||
| PKG_JSON | ||
| {{ vars.et_cli }} module-package-json |
There was a problem hiding this comment.
🩺 Stability & Availability | 🟠 Major | ⚡ Quick win
Quote the et-cli executable path.
vars.et_cli expands to an absolute path based on config_root_fwd. If the checkout path contains spaces, Bash splits the path and the task fails before module-package-json runs.
Proposed fix
-{{ vars.et_cli }} module-package-json
+"{{ vars.et_cli }}" module-package-jsonAs per coding guidelines, Windows is a first-tier supported platform.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| {{ vars.et_cli }} module-package-json | |
| "{{ vars.et_cli }}" module-package-json |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.mise/config.toml at line 1499, Quote the vars.et_cli expansion in the
module-package-json command so paths containing spaces remain a single
executable argument. Preserve the existing command and subcommand while ensuring
Bash receives the full et-cli path on all supported platforms.
Source: Coding guidelines
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Summary by CodeRabbit
New Features
Improvements
et-ws-*modules while excluding modules intended for the separate WASI runner.