Skip to content

Improve module dropdown#95

Merged
jayvdb merged 1 commit into
mainfrom
trim-index-list
Jul 21, 2026
Merged

Improve module dropdown#95
jayvdb merged 1 commit into
mainfrom
trim-index-list

Conversation

@jayvdb

@jayvdb jayvdb commented Jul 21, 2026

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • New Features

    • Added validation to keep module descriptions at 40 characters or fewer for clearer display in the module selector.
    • Added packaging support for the RustPython WASM smoke-test module.
  • Improvements

    • Updated module descriptions across supported examples for clearer, more concise wording.
    • Refined the module selector to show compatible et-ws-* modules while excluding modules intended for the separate WASI runner.
    • Improved automated generation of package metadata during module builds.

@coderabbitai

coderabbitai Bot commented Jul 21, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

Module metadata was shortened and a Semgrep rule now enforces description length. pywasm1 packaging delegates package.json generation to et-cli, while the ws-server dropdown filters modules by naming convention.

Changes

Module metadata and discovery

Layer / File(s) Summary
Module metadata and description validation
config/semgrep/module-description-length.yaml, services/ws-modules/...
Added validation for descriptions exceeding 40 characters and shortened descriptions across Python, Rust, and Zig module manifests. Added pywasm1 project metadata with index.js as its main entry.
pywasm1 package metadata generation
.mise/config.toml
The pywasm1 build task now depends on build-et-cli and invokes module-package-json instead of generating pkg/package.json inline.
ws-server module discovery filtering
services/ws-server/static/app.js
The dropdown now processes only et-ws- modules and excludes et-ws-wasi-* modules before fetching package metadata.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related PRs

Suggested reviewers: pierre-tenedero

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title is concise and clearly relates to the main change: improving the module dropdown behavior.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch trim-index-list

Comment @coderabbitai help to get the list of available commands.

@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity · 0 duplication

Metric Results
Complexity 0
Duplication 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@jayvdb
jayvdb marked this pull request as ready for review July 21, 2026 07:26

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.mise/config.toml:
- Line 1499: Quote the vars.et_cli expansion in the module-package-json command
so paths containing spaces remain a single executable argument. Preserve the
existing command and subcommand while ensuring Bash receives the full et-cli
path on all supported platforms.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: f02a3229-d4c3-4b69-aded-f1cbff1539a4

📥 Commits

Reviewing files that changed from the base of the PR and between 7adb78f and 9c741b6.

📒 Files selected for processing (10)
  • .mise/config.toml
  • config/semgrep/module-description-length.yaml
  • services/ws-modules/pyeye1/pyproject.toml
  • services/ws-modules/pywasm1/pyproject.toml
  • services/ws-modules/wasi-comm1/Cargo.toml
  • services/ws-modules/wasi-data1/Cargo.toml
  • services/ws-modules/wasi-graphics-info/pyproject.toml
  • services/ws-modules/zig-data1/build.zig.zon
  • services/ws-modules/zig-except1/build.zig.zon
  • services/ws-server/static/app.js

Comment thread .mise/config.toml
]
}
PKG_JSON
{{ vars.et_cli }} module-package-json

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🩺 Stability & Availability | 🟠 Major | ⚡ Quick win

Quote the et-cli executable path.

vars.et_cli expands to an absolute path based on config_root_fwd. If the checkout path contains spaces, Bash splits the path and the task fails before module-package-json runs.

Proposed fix
-{{ vars.et_cli }} module-package-json
+"{{ vars.et_cli }}" module-package-json

As per coding guidelines, Windows is a first-tier supported platform.

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
{{ vars.et_cli }} module-package-json
"{{ vars.et_cli }}" module-package-json
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.mise/config.toml at line 1499, Quote the vars.et_cli expansion in the
module-package-json command so paths containing spaces remain a single
executable argument. Preserve the existing command and subcommand while ensuring
Bash receives the full et-cli path on all supported platforms.

Source: Coding guidelines

@codecov

codecov Bot commented Jul 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@jayvdb
jayvdb requested a review from pierre-tenedero July 21, 2026 07:51
@jayvdb
jayvdb merged commit 80b5b22 into main Jul 21, 2026
25 of 27 checks passed
@jayvdb
jayvdb deleted the trim-index-list branch July 21, 2026 07:58
@coderabbitai coderabbitai Bot mentioned this pull request Jul 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants