Skip to content

Comments

[1888][eval] Refactor Reader class#1889

Open
mtar wants to merge 1 commit intoecmwf:developfrom
mtar:1888-abtract_reader_class
Open

[1888][eval] Refactor Reader class#1889
mtar wants to merge 1 commit intoecmwf:developfrom
mtar:1888-abtract_reader_class

Conversation

@mtar
Copy link
Contributor

@mtar mtar commented Feb 20, 2026

Description

This PR introduces some refactoring on the Reader class in io_reader.

The changes include:

  • Reader is an abstract class that cannot be instantiated
  • docstrings are more descriptive
  • helper functions to avoid code repetition
  • change assertions into exceptions
  • fix of spelling errors

Issue Number

Closes #1888

Is this PR a draft? Mark it as draft.

Checklist before asking for review

  • I have performed a self-review of my code
  • My changes comply with basic sanity checks:
    • I have fixed formatting issues with ./scripts/actions.sh lint
    • I have run unit tests with ./scripts/actions.sh unit-test
    • I have documented my code and I have updated the docstrings.
    • I have added unit tests, if relevant
  • I have tried my changes with data and code:
    • I have run the integration tests with ./scripts/actions.sh integration-test
    • (bigger changes) I have run a full training and I have written in the comment the run_id(s): launch-slurm.py --time 60
    • (bigger changes and experiments) I have shared a hegdedoc in the github issue with all the configurations and runs for this experiments
  • I have informed and aligned with people impacted by my change:
    • for config changes: the MatterMost channels and/or a design doc
    • for changes of dependencies: the MatterMost software development channel

@mtar mtar marked this pull request as ready for review February 20, 2026 10:22
@mtar mtar changed the title [eval] Abstract Reader class [eval] Refactor Reader class Feb 20, 2026
@mtar mtar changed the title [eval] Refactor Reader class [1888][eval] Refactor Reader class Feb 20, 2026
@github-actions github-actions bot added the eval anything related to the model evaluation pipeline label Feb 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

eval anything related to the model evaluation pipeline

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

Make Reader class abstract

1 participant