Skip to content

Comments

[1731][eval][infra] refactoring eval readers#1858

Closed
mtar wants to merge 15 commits intoecmwf:developfrom
mtar:1731-readers
Closed

[1731][eval][infra] refactoring eval readers#1858
mtar wants to merge 15 commits intoecmwf:developfrom
mtar:1731-readers

Conversation

@mtar
Copy link
Contributor

@mtar mtar commented Feb 17, 2026

Description

This PR cleans up the evaluation readers. Comments and doctrings are added/extended. Changes in functions.

  • Reader abstract base class
  • MergeReader in merge_reader.py

Issue Number

Closes #1731

Is this PR a draft? Mark it as draft.

Checklist before asking for review

  • I have performed a self-review of my code
  • My changes comply with basic sanity checks:
    • I have fixed formatting issues with ./scripts/actions.sh lint
    • I have run unit tests with ./scripts/actions.sh unit-test
    • I have documented my code and I have updated the docstrings.
    • I have added unit tests, if relevant
  • I have tried my changes with data and code:
    • I have run the integration tests with ./scripts/actions.sh integration-test
    • (bigger changes) I have run a full training and I have written in the comment the run_id(s): launch-slurm.py --time 60
    • (bigger changes and experiments) I have shared a hegdedoc in the github issue with all the configurations and runs for this experiments
  • I have informed and aligned with people impacted by my change:
    • for config changes: the MatterMost channels and/or a design doc
    • for changes of dependencies: the MatterMost software development channel

@mtar mtar changed the title [eval][infra] refactoring eval readers [1731][eval][infra] refactoring eval readers Feb 17, 2026
@github-actions github-actions bot added data Anything related to the datasets used in the project eval anything related to the model evaluation pipeline labels Feb 19, 2026
@mtar
Copy link
Contributor Author

mtar commented Feb 23, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

data Anything related to the datasets used in the project eval anything related to the model evaluation pipeline

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Refactor evaluation readers

1 participant