Add query appender - #587
Open
daviddallakyan2005 wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #586. Please merge that first.
GitHub has to target
mainuntil the parent PRs land, so the Files tab will also show those slices. Slice only:daviddallakyan2005:appender-chunks...daviddallakyan2005:appender-query
Adds
conn.appender_query(query, types, names=None, table_name=None), wrapping C++QueryAppender. The default table name isappended_data.Follows #369
append()converts each cell to a Value and uses the C++ row Append API. Useappend_chunkfor bulk inserts, which writes into vectors in place.How to test
tests/fast/test_appender_query.py: 2 passed. Parent appender tests still pass.On the full stack: 21 passed across appender, insert, context manager, and module tests.
tests/fastexcluding spark: 1655 passed.