Add Python Appender for scalar create, append, flush and close - #585
Open
daviddallakyan2005 wants to merge 1 commit into
Open
Add Python Appender for scalar create, append, flush and close#585daviddallakyan2005 wants to merge 1 commit into
daviddallakyan2005 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Python still has no Appender. This adds
conn.appender(table, schema=None, catalog=None)withappend,flush,close, a context manager, andcolumn_count, for scalar types.Follows #369
This is the first of three stacked PRs. Chunks: #586. Query appender: #587.
append()converts each cell to a Value and uses the C++ row Append API. Useappend_chunkfor bulk inserts, which writes into vectors in place.append_chunkis #586.This does not change
conn.append(table, df).How to test
After this commit: 9 new tests in
tests/fast/test_appender.pypassed. Insert, context manager, and module tests also passed.On the full stack I also ran
tests/fastexcluding spark: 1655 passed. Two failures (missingreraisefixture, missingtyping_extensionsfor experimental spark) fail the same way on currentmain.