Skip to content

feat: add security_logging playbook and simplify category detail rendering #315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
l50 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: add security_logging playbook and simplify category detail rendering #315

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 5 additions & 14 deletions cli/internal/validate/panel.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,21 +194,12 @@ func renderCategoryColumn(cats []categoryStats, width int) string {
counts := fmt.Sprintf("%d/%d", c.pass, c.total)
countsCell := padRight(styleMuted.Render(counts), countsWidth)

var detail string
switch {
case c.fail > 0 && c.warn > 0:
detail = fmt.Sprintf("x%d !%d", c.fail, c.warn)
case c.fail > 0:
detail = fmt.Sprintf("x%d", c.fail)
case c.warn > 0:
detail = fmt.Sprintf("!%d", c.warn)
}
// Only show the fail/warn breakdown when both are present; otherwise
// pass/total + the row icon already convey it (e.g. `[x] 3/6` is 3
// fails, `[!] 3/6` is 3 warns).
var detailCell string
switch {
case c.fail > 0:
detailCell = styleErr.Render(detail)
case c.warn > 0:
detailCell = styleWarn.Render(detail)
if c.fail > 0 && c.warn > 0 {
detailCell = styleErr.Render(fmt.Sprintf("x%d !%d", c.fail, c.warn))
}
detailCell = padRight(detailCell, detailWidth)

Expand Down
5 changes: 5 additions & 0 deletions playbooks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ NHA:
- ad-acl.yml
- servers.yml
- security.yml
- security_logging.yml
- vulnerabilities.yml

SCCM:
Expand All @@ -30,6 +31,7 @@ SCCM:
- ad-acl.yml
- servers.yml
- security.yml
- security_logging.yml
- vulnerabilities.yml
- sccm-install.yml
# Waiting 10 minutes for the install to complete
Expand All @@ -54,6 +56,7 @@ GOAD-Mini:
- adcs.yml
- ad-acl.yml
- security.yml
- security_logging.yml
- vulnerabilities.yml

DRACARYS:
Expand All @@ -68,6 +71,7 @@ DRACARYS:
- klink.yml
- keepass.yml
- security.yml
- security_logging.yml
- vulnerabilities.yml
- reboot.yml
- glpi.yml
Expand All @@ -91,4 +95,5 @@ default:
- ad-acl.yml
- servers.yml
- security.yml
- security_logging.yml
- vulnerabilities.yml
Loading