feat: add security_logging playbook and simplify category detail rendering#315
Open
l50 wants to merge 1 commit into
Open
feat: add security_logging playbook and simplify category detail rendering#315l50 wants to merge 1 commit into
l50 wants to merge 1 commit into
Conversation
…panel detail rendering **Added:** - `security_logging.yml` to all environment playbook lists (NHA, SCCM, GOAD-Mini, DRACARYS, default) in `playbooks.yml` **Changed:** - Simplified category detail cell rendering in `panel.go` to only show the combined fail/warn breakdown (e.g. `x3 !2`) when both are present, since the row icon and pass/total count already convey the state when only one condition exists
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Key Changes:
security_logging.ymlto all playbook profiles (NHA, SCCM, GOAD-Mini, DRACARYS, default)Added:
security_logging.ymlto all five playbook profiles inplaybooks.yml(NHA, SCCM, GOAD-Mini, DRACARYS, and default)Changed:
renderCategoryColumn(cli/internal/validate/panel.go) to only display the combinedx{fail} !{warn}breakdown when both fails and warns are present simultaneously, since a row icon like[x]or[!]already makes the single-condition state self-evident from the pass/total count alone