Always use config to set default value of timeout in check version#2108
Always use config to set default value of timeout in check version#2108sunnyakaxd wants to merge 1 commit intodpkp:masterfrom
Conversation
jeffwidman
left a comment
There was a problem hiding this comment.
I'm a little torn on this one... throughout the code there are a bunch of places we explicitly pass in the config value, and then here we fall back to the config as a default... if we go this route, then we should do it completely and not explicitly pass it in elsewhere and just let them fallback to this default...
Also, there's another default of 2 in conn.check_version() which should probably also default to this value as well for consistency. (although it doesn't look like the default value is ever really used as the only places its called have a passed-in value)
I'd like to hear input though from @dpkp / @tvoinarovskyi on whether they'd rather we get to this value by default or by explicitly passing it in everywhere
9c8c8af to
8ebb14c
Compare
|
Fixed in #2496 |
This change is