Closed
Conversation
The docstring states the `api_version` and `api_version_auto_timeout_ms` are used to decide if check_version() has to be called and for how long it has to wait, now the function follows that behavior, consistent with the `KafkaClient`
Author
|
I found later that this behavior was introduced in #1953 because if Could it make sense then to remove the |
Contributor
|
Possibly related #2107 / #2108 ... as I noted #2108 (review), we should probably step-back and re-examine the way this gets handled so that it's consistent everywhere. |
9c8c8af to
8ebb14c
Compare
Owner
|
Addressed in #2496 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The docstring states the
api_versionandapi_version_auto_timeout_msare used to decide if check_version() has to be called and for how long it has to wait, now the function follows that behavior, consistent with theKafkaClientThis could help with problems like #1308
This change is