Skip to content

Improve argument handling in ProcessHelper and use read-only store access in CertHelper #5151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LoopedBard3 merged 1 commit into from
Mar 17, 2026
Merged

Improve argument handling in ProcessHelper and use read-only store access in CertHelper #5151

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/tools/CertHelper/Program.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ static async Task<int> Main(string[] args)
Console.Error.WriteLine(ex.StackTrace);
}

using (var store = new X509Store(StoreName.My, StoreLocation.CurrentUser, OpenFlags.ReadWrite))
using (var store = new X509Store(StoreName.My, StoreLocation.CurrentUser, OpenFlags.ReadOnly))
{
foreach(var cert in store.Certificates.Find(X509FindType.FindBySubjectName, "dotnetperf.microsoft.com", false))
{
Expand Down
4 changes: 2 additions & 2 deletions src/tools/ScenarioMeasurement/Util/ProcessHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ public Process RunWithNoExit()
if (!Util.IsWindows() && RootAccess)
{
psi.FileName = "sudo";
psi.Arguments = Executable + " " + Arguments;
psi.Arguments = "-- " + Executable + " " + Arguments;
}
else
{
Expand Down Expand Up @@ -191,7 +191,7 @@ public ProcessResult Run()
if (!Util.IsWindows() && RootAccess)
{
psi.FileName = "sudo";
psi.Arguments = Executable + " " + Arguments;
psi.Arguments = "-- " + Executable + " " + Arguments;
}
else
{
Expand Down
Loading