Improve argument handling in ProcessHelper and use read-only store access in CertHelper#5151
Open
LoopedBard3 wants to merge 1 commit intodotnet:mainfrom
Open
Improve argument handling in ProcessHelper and use read-only store access in CertHelper#5151LoopedBard3 wants to merge 1 commit intodotnet:mainfrom
LoopedBard3 wants to merge 1 commit intodotnet:mainfrom
Conversation
…cess in CertHelper - Add -- separator to sudo invocations in RawProcessHelper and ManagedProcessHelper to properly delimit the command from sudo options - Change certificate store open from ReadWrite to ReadOnly when only reading certificates in CertHelper Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates two internal tools: it hardens how elevated (sudo) processes are invoked in ScenarioMeasurement, and reduces certificate store permissions in CertHelper.
Changes:
- Prefix sudo-invoked commands with
--to stop sudo option parsing before the executable/args. - Open the CurrentUser
Mycertificate store as read-only when exporting matching certificates.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/tools/ScenarioMeasurement/Util/ProcessHelper.cs |
Adjusts sudo argument construction to include -- before passing executable/args. |
src/tools/CertHelper/Program.cs |
Switches cert store open flags from read-write to read-only for export-only usage. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Comment on lines
74
to
78
| if (!Util.IsWindows() && RootAccess) | ||
| { | ||
| psi.FileName = "sudo"; | ||
| psi.Arguments = Executable + " " + Arguments; | ||
| psi.Arguments = "-- " + Executable + " " + Arguments; | ||
| } |
Member
Author
There was a problem hiding this comment.
This makes sense but any issues would already be present and I would like to make minimal changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve argument handling in ProcessHelper and use read-only store access in CertHelper