[CryptoTokenKit] Update bindings all the way to Xcode 26.4 by dalexsoto · Pull Request #25025 · dotnet/macios

dalexsoto · 2026-03-25T21:23:12Z

No description provided.

rolfbjarne · 2026-03-26T10:07:39Z

src/cryptotokenkit.cs

+			<returns>
+			          <para class="improve-task-t-return-type-description">A task that represents the asynchronous CreateNfcSlot operation.  The value of the TResult parameter is of type System.Action&lt;CryptoTokenKit.TKSmartCardSlotNFCSession,Foundation.NSError&gt;.</para>
+			        </returns>
+			<remarks>To be added.</remarks>


Copilot should never add 'To be added.'

rolfbjarne · 2026-03-26T10:09:31Z

src/cryptotokenkit.cs

+		[iOS (26, 0), Mac (26, 0), TV (26, 0), MacCatalyst (26, 0)]
+		[Export ("getSmartCardWithError:")]
+		[return: NullAllowed]
+		TKSmartCard GetSmartCard (out NSError error);


Suggested change

TKSmartCard GetSmartCard (out NSError error);

TKSmartCard GetSmartCard ([NullAllowed] out NSError error);

rolfbjarne · 2026-03-26T10:09:43Z

src/cryptotokenkit.cs

+		string SlotName { get; }
+
+		[Export ("updateWithMessage:error:")]
+		bool Update (string message, out NSError error);


Suggested change

bool Update (string message, out NSError error);

bool Update (string message, [NullAllowed] out NSError error);

rolfbjarne · 2026-03-26T10:09:59Z

src/cryptotokenkit.cs

+		string [] RegisteredSmartCardTokens { get; }
+
+		[Export ("registerSmartCardWithTokenID:promptMessage:error:")]
+		bool RegisterSmartCard (string tokenId, string promptMessage, out NSError error);


Suggested change

bool RegisterSmartCard (string tokenId, string promptMessage, out NSError error);

bool RegisterSmartCard (string tokenId, string promptMessage, [NullAllowed] out NSError error);

rolfbjarne · 2026-03-26T10:10:29Z

src/cryptotokenkit.cs

+		bool RegisterSmartCard (string tokenId, string promptMessage, out NSError error);
+
+		[Export ("unregisterSmartCardWithTokenID:error:")]
+		bool UnregisterSmartCard (string tokenId, out NSError error);


Suggested change

bool UnregisterSmartCard (string tokenId, out NSError error);

bool UnregisterSmartCard (string tokenId, [NullAllowed] out NSError error);

- Remove 'To be added.' from XML doc remarks - Add [NullAllowed] to out NSError parameters in GetSmartCard, Update, RegisterSmartCard, and UnregisterSmartCard Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

vs-mobiletools-engineering-service2 · 2026-03-31T22:33:48Z

✅ [CI Build #8c60d75] Build passed (Build packages) ✅

Pipeline on Agent
Hash: 8c60d756f184d5d5eced8da9ba5f607bb16c1539 [PR build]

vs-mobiletools-engineering-service2 · 2026-03-31T22:37:53Z

✅ [PR Build #8c60d75] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: 8c60d756f184d5d5eced8da9ba5f607bb16c1539 [PR build]

vs-mobiletools-engineering-service2 · 2026-03-31T22:50:07Z

✅ API diff for current PR / commit

NET (empty diffs)

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

✅ API diff vs stable

NET (empty diffs)

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 8c60d756f184d5d5eced8da9ba5f607bb16c1539 [PR build]

vs-mobiletools-engineering-service2 · 2026-03-31T23:01:06Z

✅ [CI Build #8c60d75] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: 8c60d756f184d5d5eced8da9ba5f607bb16c1539 [PR build]

vs-mobiletools-engineering-service2 · 2026-04-01T07:57:51Z

🚀 [CI Build #8c60d75] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 156 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 6 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 15 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 12 tests passed. [attempt 3] Html Report (VSDrops) Download
✅ monotouch (tvOS): All 11 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ sharpie: All 1 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

macOS tests

✅ Tests on macOS Monterey (12): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Ventura (13): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Sonoma (14): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Sequoia (15): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Tahoe (26): All 5 tests passed. Html Report (VSDrops) Download

Linux Build Verification

✅ Linux build succeeded

Pipeline on Agent
Hash: 8c60d756f184d5d5eced8da9ba5f607bb16c1539 [PR build]

[CryptoTokenKit] Update bindings all the way to Xcode 26.4

b92a0f4

dalexsoto requested a review from rolfbjarne March 25, 2026 21:23

dalexsoto added this to the xcode26.4 milestone Mar 25, 2026

dalexsoto added the copilot label Mar 25, 2026

dalexsoto enabled auto-merge (squash) March 25, 2026 21:39

This comment has been minimized.

Sign in to view

rolfbjarne requested changes Mar 26, 2026

View reviewed changes

This comment has been minimized.

Sign in to view

dalexsoto and others added 2 commits March 31, 2026 17:11

Merge branch 'main' into dev/alex/CryptoTokenKit

946abd1

Address PR review feedback for CryptoTokenKit bindings

8c60d75

- Remove 'To be added.' from XML doc remarks - Add [NullAllowed] to out NSError parameters in GetSmartCard, Update, RegisterSmartCard, and UnregisterSmartCard Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

This comment has been minimized.

Sign in to view

dalexsoto requested a review from rolfbjarne April 1, 2026 01:22

This comment has been minimized.

Sign in to view

rolfbjarne approved these changes Apr 1, 2026

View reviewed changes

dalexsoto merged commit e1556b4 into main Apr 1, 2026
48 checks passed

	TKSmartCard GetSmartCard (out NSError error);
	TKSmartCard GetSmartCard ([NullAllowed] out NSError error);

	bool Update (string message, out NSError error);
	bool Update (string message, [NullAllowed] out NSError error);

	bool RegisterSmartCard (string tokenId, string promptMessage, out NSError error);
	bool RegisterSmartCard (string tokenId, string promptMessage, [NullAllowed] out NSError error);

	bool UnregisterSmartCard (string tokenId, out NSError error);
	bool UnregisterSmartCard (string tokenId, [NullAllowed] out NSError error);

Conversation

dalexsoto commented Mar 25, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

rolfbjarne Mar 26, 2026

Choose a reason for hiding this comment

Uh oh!

rolfbjarne Mar 26, 2026

Choose a reason for hiding this comment

Uh oh!

rolfbjarne Mar 26, 2026

Choose a reason for hiding this comment

Uh oh!

rolfbjarne Mar 26, 2026

Choose a reason for hiding this comment

Uh oh!

rolfbjarne Mar 26, 2026

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Mar 31, 2026

✅ [CI Build #8c60d75] Build passed (Build packages) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Mar 31, 2026

✅ [PR Build #8c60d75] Build passed (Detect API changes) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Mar 31, 2026

✅ API diff for current PR / commit

✅ API diff vs stable

ℹ️ Generator diff

Uh oh!

vs-mobiletools-engineering-service2 commented Mar 31, 2026

✅ [CI Build #8c60d75] Build passed (Build macOS tests) ✅

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Apr 1, 2026

🚀 [CI Build #8c60d75] Test results 🚀

Test results

Tests counts

macOS tests

Linux Build Verification

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants