Add pcov to PHP 7.1-8.4 images - #27
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011sNqP1fsSPcDjcmLhWjNmD
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011sNqP1fsSPcDjcmLhWjNmD
The test job ran "make test-8.5", which is not a target. The Makefile provides test-cli-% and test-fpm-% pattern rules, so map each matrix item to the target matching the image it builds. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011sNqP1fsSPcDjcmLhWjNmD
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the pcov code coverage driver to the PHP images, mirroring dockette/ci#17 which does the same for the Alpine CI images.
Changes
One line per Dockerfile, slotted alphabetically before
pdoin the existingapt install --no-install-recommendslist:Applied to
7.1,7.2,7.3,7.4,8.0,8.1,8.2,8.3,8.4and each matching-fpmvariant (18 Dockerfiles), plus the extension list inREADME.md.Versions left out
php8.5-pcovcould not be confirmed as published at deb.sury.org; PHP 8.5 extension packages were still landing there and pcov was among those reported missing. Since8.5is what the fasttestjob builds, guessing here would block the whole pipeline. Easy follow-up once availability is confirmed.Verification
Not built locally — this environment has no Docker daemon and outbound access to the package indexes is blocked by the network egress proxy, so the
aptpackage names could not be resolved here. The build matrix on this PR is what actually confirms them.Note that pcov ships enabled by default (
pcov.enabled=1). These images carry no xdebug, so there is no extension conflict, but coverage collection will be active unless disabled viaconf.d/custom.ini.Generated by Claude Code