Add Alpine 3.23 and 3.24 - #4
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011sNqP1fsSPcDjcmLhWjNmD
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds base images for Alpine 3.23 and 3.24. Both are published upstream (latest patches 3.23.5 and 3.24.1), so this brings the repo up to current.
Changes
3.23/Dockerfileand3.24/Dockerfile— byte-identical to3.22/Dockerfileapart from theFROMline, so thedfx/ UID 1000 user, theapk update && upgrade, and the existingENV TERM xtermstyle all carry over unchanged. Deliberately copied from3.22, not fromedge, sinceedge/Dockerfilestill has a deprecatedMAINTAINERline.Verified that every matrix entry has a matching Dockerfile and that no version directory is missing from the matrix (3.1–3.6 remain commented out, as before).
Why now
dockette/ci's node24 image buildsFROM dockette/alpine:3.23, which does not exist on Docker Hub yet — the newest published tag is 3.22. That is currently breaking CI indockette/ci(see dockette/ci#17). Once this merges and master publishesdockette/alpine:3.23, that failure resolves with no change needed indockette/ci.Notes
on: push: branches: [master], so nothing builds on a branch — 3.23 and 3.24 are first exercised when this merges. If you want branch builds without publishing, the same change applied in Add PCOV extension to all PHP Docker images ci#17 and Add pcov to PHP 7.1-8.4 images php#27 works here: drop the branch filter and gate the push step ongithub.ref == 'refs/heads/master'.dockette/alpine:v3.22while the workflow actually tags images as3.22, with novprefix. That predates this PR and applies to every row; the new rows follow the existing format for consistency rather than introducing a second convention. Happy to correct the whole column separately.Generated by Claude Code