Skip to content

Add linkspector config to fix local links issue#740

Open
sbland wants to merge 1 commit into
mainfrom
ci/fix-linkspector-local-links
Open

Add linkspector config to fix local links issue#740
sbland wants to merge 1 commit into
mainfrom
ci/fix-linkspector-local-links

Conversation

@sbland

@sbland sbland commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Description

Fixes an issue with linkspector failing local links. See #533 (comment)

Type of change

  • Documentation (non-breaking change that adds or improves the documentation)
  • New feature (non-breaking change which adds functionality)
  • Optimization (non-breaking, back-end change that speeds up the code)
  • Technical work (non-breaking, change which is work as part of a new feature)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (whatever its nature)

Key checklist

  • All tests pass (eg. python -m pytest)
  • The documentation builds and looks OK (eg. mkdocs serve)
  • Pre-commit hooks run successfully (eg. pre-commit run --all-files)

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added or an issue has been opened to tackle that in the future. (Indicate issue here: # (issue))

@sbland sbland requested a review from AdrianDAlessandro June 10, 2026 08:56
@codecov

codecov Bot commented Jun 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@AdrianDAlessandro AdrianDAlessandro left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just approved this, but it seems like it's not needed anymore because the PR that this was designed to fix is no longer failing

@sbland

sbland commented Jun 11, 2026

Copy link
Copy Markdown
Contributor Author

I still get a failed report when I run Linkspector locally with the default config. It's possible the action has a different default which I'll check

@AdrianDAlessandro

Copy link
Copy Markdown
Collaborator

I still get a failed report when I run Linkspector locally with the default config. It's possible the action has a different default which I'll check

Oh right! I haven't tried to run it locally. Which links are failing when you run it locally?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants