464 implement frontend javascript testing

[sbland]

Description

Some tidying up of the frontend node code related to #529

Fixes #464

Type of change

• Documentation (non-breaking change that adds or improves the documentation)
• New feature (non-breaking change which adds functionality)
• Optimization (non-breaking, back-end change that speeds up the code)
• Technical work (non-breaking, change which is work as part of a new feature)
• Bug fix (non-breaking change which fixes an issue)
• Breaking change (whatever its nature)

Key checklist

• All tests pass (eg. python -m pytest)
• The documentation builds and looks OK (eg. mkdocs serve)
• Pre-commit hooks run successfully (eg. pre-commit run --all-files)

Further checks

• Code is commented, particularly in hard-to-understand areas
• Tests added or an issue has been opened to tackle that in the future. (Indicate issue here: # (issue))

[sbland]

Fixes #464

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

[sbland]

@AdrianDAlessandro I moved the node documentation to a separate README.md inside the node directory. This seems to have broken the mkdocs build. I tried looking through the code and docs but I can't see how to add this file.

[sbland]

@AdrianDAlessandro FYI I've rebased this onto the main branch.

[AdrianDAlessandro]

I'll be happy to review and merge this if you can rebase it onto main. Would be good to merge this before looking at moving the node configs into a sub-directory

[sbland]

@AdrianDAlessandro this is rebased back onto main and should be ready to merge

[AdrianDAlessandro]

Overall, this looks really good. I've run the tests and see that they pass. I haven't individually reviewed the tests because I am not likely to understand them. My only concern is that they might be too prescriptive. So if we make changes to the radial plots, it might cause many failures and make it difficult to update them all.

I've made some other comments, but they might be out of my naivety of best practice with node/npm/vitest, so please take it all with a grain of salt.

[sbland]

Overall, this looks really good. I've run the tests and see that they pass. I haven't individually reviewed the tests because I am not likely to understand them. My only concern is that they might be too prescriptive. So if we make changes to the radial plots, it might cause many failures and make it difficult to update them all.

I've made some other comments, but they might be out of my naivety of best practice with node/npm/vitest, so please take it all with a grain of salt.

Thanks @AdrianDAlessandro I'll take a look.

[github-actions]

🚫 [linkspector] _{reported by reviewdog 🐶}
Cannot reach https://github.com/direct-framework/direct-webapp/blob/main/node/README.md Status: 404

[sbland]

This is resolved by #740

[AdrianDAlessandro]

This doesn't seem to be failing anymore despite the change in #740 not being included in this PR.

[sbland]

@AdrianDAlessandro I've fixed the lint and build issues so this should be ready to merge now.
I've also added in a CI action to run the javascript linter. We could do with one to run the build script and check nothing changes but I'll create another issue for that.

[AdrianDAlessandro]

@sbland I have just pushed a change to fix the issue with the docs failing

[AdrianDAlessandro]

This all looks good to me now!