add a flag first_tick to ContactForceEvent #864
Open
bcolloran wants to merge 3 commits intodimforge:masterfrom
Open
add a flag first_tick to ContactForceEvent #864bcolloran wants to merge 3 commits intodimforge:masterfrom
first_tick to ContactForceEvent #864bcolloran wants to merge 3 commits intodimforge:masterfrom
Conversation
…the first tick on which corresponding contact has generated a force
Author
|
Hi @sebcrozet, any chance to get a review on this little teeny change :-) This is useful for example for playing a sound just once at the moment when a collision starts. Happy to do the implementation of a different approach if you have another suggested way of doing this! Thanks much! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a flag "first_tick" to
ContactForceEvent, that is true if this is the first tick on which a contact force has been applied by the correspondingContactPair.This seems to be a tidy solution to the issue I described in this discord issue:
https://discord.com/channels/507548572338880513/747935665076830259/1397751543700262934
Please let me know if you have any feedback or suggestions, or if you see anything incorrect. Thanks!